Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] Add birthdate in search view #1924

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[17.0][IMP] Add birthdate in search view #1924

merged 1 commit into from
Dec 19, 2024

Conversation

cvinh
Copy link

@cvinh cvinh commented Dec 10, 2024

With this PR you can filter partners with his birthdate
cc @vehi-invitu

@OCA-git-bot
Copy link
Contributor

Hi @Daemo00,
some modules you are maintaining are being modified, check this out!

@cvinh cvinh changed the title [IMP] Add birthdate in search view [17.0][IMP] Add birthdate in search view Dec 10, 2024
@rousseldenis rousseldenis added this to the 17.0 milestone Dec 10, 2024
@rousseldenis
Copy link
Contributor

@cvinh Thanks for this.

Could you improve your commit message making module name appears ?

image

Like [IMP] partner_contact_birthdate

@cvinh cvinh force-pushed the 17.0-imp-add_birthdate_search_view branch from 5714551 to f764c9a Compare December 10, 2024 08:21
Daemo00
Daemo00 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Daemo00 Daemo00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1924-by-Daemo00-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 686c172. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 429f07d into OCA:17.0 Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daemo00 Daemo00 Daemo00 approved these changes

Assignees
No one assigned
Labels
enhancement merged 🎉 needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cvinh @OCA-git-bot @rousseldenis @Daemo00