[FIX] partner_company_type: make unique constraint dependent on country #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
len-foss
force-pushed
the
12.0-company_type_by_country
branch
3 times, most recently
from
e88608e to
005918e
Compare
len-foss
force-pushed
the
12.0-company_type_by_country
branch
from
005918e to
4d6ea5c
Compare
rousseldenis
reviewed
Dec 6, 2024
| "unique (name, country_id)", | ||
| "Partner Company Type already exists for this country!" | ||
| ), | ||
| ( |
There was a problem hiding this comment.
@len-foss And why not using the EXCLUDE with all the conditions (and removing unique constraint) ?
There was a problem hiding this comment.
I generally prefer 2 simple and stupid statements to having only 1 but complicated. Unless there is a simple form to combine these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.