Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] partner_identification_unique_by_category: Migration to 18.0 #1859

Merged
merged 11 commits into from
Oct 27, 2024
Merged

[18.0][MIG] partner_identification_unique_by_category: Migration to 18.0 #1859

merged 11 commits into from
Oct 27, 2024

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Oct 9, 2024 •
edited
Loading

No description provided.

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch 3 times, most recently from f2d8ef6 to d25bbde Compare October 10, 2024 08:06
TDu
TDu reviewed Oct 11, 2024
View reviewed changes
...er_identification_unique_by_category/tests/test_partner_identification_unique_by_category.py Outdated

from odoo.exceptions import ValidationError

from odoo.addons.base.tests.common import SavepointCaseWithUserDemo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo.addons.base.tests.common import SavepointCaseWithUserDemo
from odoo.tests.common import TransactionCase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TDu , I have updated it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually there's a better one that takes care of turning off tracking and other flags: from odoo.addons.base.tests.common import BaseCommon

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch from d25bbde to d0bfab2 Compare October 14, 2024 03:27
@chaule97 chaule97 requested a review from TDu October 14, 2024 03:32
@rousseldenis
Copy link
Contributor

/caobot migration partner_identification_unique_by_category

@rousseldenis rousseldenis added this to the 18.0 milestone Oct 18, 2024
@rousseldenis
Copy link
Contributor

@chaule97 Thanks for this. Don't forget to add the depending PR in this one description to help review

@OCA-git-bot
Copy link
Contributor

Sorry @TDu you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch from d0bfab2 to 65ca92a Compare October 25, 2024 04:39
TDu and others added 10 commits October 25, 2024 17:05
@TDu @chaule97
[13.0][ADD] partner_identification_unique_by_category
d463d83 
This module extends the module `partner_identification` to enforce having
unique id numbers by categories.
This option can be set by category.

[UPD] Update partner_identification_unique_by_category.pot

[UPD] README.rst

[ADD] icon.png
@braisab @chaule97
[MIG] partner_identification_unique_by_category: Migration to 14.0
0a9fb91
@oca-travis @chaule97
[UPD] Update partner_identification_unique_by_category.pot
6eb62bd
@OCA-git-bot @chaule97
[UPD] README.rst
008c05f
@OCA-git-bot @chaule97
partner_identification_unique_by_category 14.0.1.0.1
9ba4ece
@OCA-git-bot @chaule97
[UPD] README.rst
8e073d3
@Ivorra78 @chaule97
Added translation using Weblate (Spanish)
8902f03
@Ivorra78 @chaule97
Translated using Weblate (Spanish)
a5581c1 
Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_identification_unique_by_category
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_identification_unique_by_category/es/
@mymage @chaule97
Added translation using Weblate (Italian)
71c1cbe
@chaule97
[IMP] partner_identification_unique_by_category: pre-commit auto fixes
d7a57f3
@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch from 65ca92a to 14a4d4d Compare October 25, 2024 10:06
@chaule97
Copy link
Author

chaule97 commented Oct 25, 2024 •
edited
Loading

Salut @rousseldenis , I have rebase. Could you merge again?

@rousseldenis
Copy link
Contributor

Salut @rousseldenis , I have rebase. Could you merge again?

migrationcommand is not a merge. Just to update Migration PR 😅

simahawk
simahawk approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark for author name

partner_identification_unique_by_category/__manifest__.py Outdated
"license": "AGPL-3",
"depends": ["partner_identification"],
"data": ["views/res_partner_id_category_view.xml"],
"author": "Camptocamp SA, Odoo Community Association (OCA)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "Camptocamp SA, Odoo Community Association (OCA)",
"author": "Camptocamp, Odoo Community Association (OCA)",

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch from 14a4d4d to 0cac5b8 Compare October 25, 2024 14:48
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1859-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 880f12b into OCA:18.0 Oct 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 644ddcb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
9 participants
@chaule97 @rousseldenis @OCA-git-bot @simahawk @TDu @braisab @oca-travis @Ivorra78 @mymage