Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_location_nuts: Migration to 17.0 #1792

Merged
merged 40 commits into from
Jul 23, 2024
Merged

[17.0][MIG] base_location_nuts: Migration to 17.0 #1792

merged 40 commits into from
Jul 23, 2024

Conversation

salvorapi
Copy link

No description provided.

@salvorapi salvorapi force-pushed the 17.0-mig-base_location_nuts branch 3 times, most recently from 554c2bb to caf1211 Compare June 25, 2024 10:03
@salvorapi salvorapi mentioned this pull request Jun 25, 2024
Open
66 tasks
@salvorapi salvorapi force-pushed the 17.0-mig-base_location_nuts branch from caf1211 to 306db30 Compare July 5, 2024 08:17
TheMule71
TheMule71 approved these changes Jul 5, 2024
View reviewed changes
Copy link

@TheMule71 TheMule71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deriman-Alonso
Deriman-Alonso approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Deriman-Alonso Deriman-Alonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, code review.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@FernandoRomera
Copy link
Contributor

@salvorapi Can you include this pr #1815

@salvorapi
Copy link
Author

@salvorapi Can you include this pr #1815

Sure! There is some specific procedure to include PR or just merge the commit from #1815 ?

@FernandoRomera
Copy link
Contributor

@salvorapi just merge the commit.

FernandoRomera
FernandoRomera approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@FernandoRomera FernandoRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FernandoRomera
Copy link
Contributor

Hi @rafaelbn, @edlopen,
Can you merge this PR.

@FernandoRomera FernandoRomera mentioned this pull request Jul 19, 2024
Merged
1 task
@HaraldPanten
Copy link
Contributor

/ocabot migration base_location_nuts

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 22, 2024
@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1792-by-HaraldPanten-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 22, 2024
@OCA-git-bot
Merge PR #1792 into 17.0
1b5f8da 
Signed-off-by HaraldPanten
@OCA-git-bot
Copy link
Contributor

@HaraldPanten The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name partner-contact --branch 17.0 --addons-dir /tmp/tmpm49qjpcq --commit failed with output:

Both .md and .rst found for DESCRIPTION. Please remove one of /tmp/tmpm49qjpcq/base_location_nuts/readme/DESCRIPTION.rst or /tmp/tmpm49qjpcq/base_location_nuts/readme/DESCRIPTION.md.

@HaraldPanten
Copy link
Contributor

@salvorapi Please, check failures. You have other binary files added by mistake in this PR.

THX.

@salvorapi salvorapi force-pushed the 17.0-mig-base_location_nuts branch from fe049ca to ceed5d5 Compare July 22, 2024 12:13
@salvorapi
Copy link
Author

@salvorapi Please, check failures. You have other binary files added by mistake in this PR.

THX.

done. I hope now it's ok. :)

@FernandoRomera
Copy link
Contributor

FernandoRomera commented Jul 23, 2024 •
edited
Loading

@HaraldPanten Can you check and merge if all Ok?

@edlopen
Copy link
Member

edlopen commented Jul 23, 2024

/ocabot merge nobump

kos94ok-3D and others added 22 commits July 23, 2024 15:40
@kos94ok-3D @salvorapi
[IMP] base_location_nuts: black, isort, prettier
4ad713a
@kos94ok-3D @salvorapi
[MIG] base_location_nuts: Migration to 14.0
e51b935
@kos94ok-3D @salvorapi
[IMP] base_location_nuts: add context on partner form and reload page…
adc983e 
… after import
@kos94ok-3D @salvorapi
[IMP] base_location_nuts: use compute field in domain instead of retu…
d5d81b7 
…rn domain in onchange
@gaso @salvorapi
[IMP] base_location_nuts: black, isort, prettier
4152a90
@gaso @salvorapi
[MIG] base_location_nuts: Migration to 15.0
8b722fb
@salvorapi
[UPD] Update base_location_nuts.pot
9fcc5a5
@OCA-git-bot @salvorapi
[UPD] README.rst
bc04644
@sysadminmatmoz @salvorapi
Translated using Weblate (Slovenian)
cb8c68c 
Currently translated at 69.2% (27 of 39 strings)

Translation: partner-contact-15.0/partner-contact-15.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-base_location_nuts/sl/
@LoisRForgeFlow @salvorapi
[TEMP] base_location_nuts: do not run tests as it makes all CI pipeli…
64ff8a1 
…nes to fail

Issue details: OCA#1557
@OCA-git-bot @salvorapi
base_location_nuts 15.0.1.0.1
656802d
@OCA-git-bot @salvorapi
[UPD] README.rst
552f98b
@douglascstd @salvorapi
Translated using Weblate (Portuguese (Brazil))
01fd3f1 
Currently translated at 43.5% (17 of 39 strings)

Translation: partner-contact-15.0/partner-contact-15.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-base_location_nuts/pt_BR/
@Ivorra78 @salvorapi
Translated using Weblate (Spanish)
57c79b6 
Currently translated at 100.0% (39 of 39 strings)

Translation: partner-contact-15.0/partner-contact-15.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-base_location_nuts/es/
@weblate @salvorapi
Update translation files
2c78bc9 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-15.0/partner-contact-15.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-base_location_nuts/
@Ivorra78 @salvorapi
Translated using Weblate (Spanish)
ad5337f 
Currently translated at 100.0% (41 of 41 strings)

Translation: partner-contact-15.0/partner-contact-15.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-base_location_nuts/es/
@edlopen @salvorapi
[16.0][MIG] base_location_nuts
142c87a 
MT-1655
@salvorapi
[UPD] Update base_location_nuts.pot
dc81630
@OCA-git-bot @salvorapi
[BOT] post-merge updates
982ae87
@mymage @salvorapi
Translated using Weblate (Italian)
fe36d72 
Currently translated at 100.0% (41 of 41 strings)

Translation: partner-contact-16.0/partner-contact-16.0-base_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location_nuts/it/
@salvorapi
[IMP] base_location_nuts: pre-commit auto fixes
9615386
@salvorapi
[MIG] base_location_nuts: Migration to 17.0
5899972
@salvorapi salvorapi force-pushed the 17.0-mig-base_location_nuts branch from ceed5d5 to 5899972 Compare July 23, 2024 13:40
@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1792-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b203366 into OCA:17.0 Jul 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bba766e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deriman-Alonso Deriman-Alonso Deriman-Alonso approved these changes

@FernandoRomera FernandoRomera FernandoRomera approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@TheMule71 TheMule71 TheMule71 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.