[IMP] partner_(ref,vat)_unique: enable name search by the VAT Identification Number and Reference #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luisg123v could you review, please? |
desdelinux
approved these changes
Mar 6, 2024
luisg123v
suggested changes
Mar 7, 2024
|
PR title:
|
CLaurelB
changed the title
CLaurelB
force-pushed
the
15.0-add_name_search_by_ref_and_vat-CLaurelB
branch
2 times, most recently
from
2836ccc to
c978f3c
Compare
desdelinux
approved these changes
Mar 12, 2024
moylop260
reviewed
Mar 12, 2024
CLaurelB
force-pushed
the
15.0-add_name_search_by_ref_and_vat-CLaurelB
branch
3 times, most recently
from
03efe4c to
6ec69cd
Compare
|
Hello @pedrobaeza @yajo Could you review, please? Regards. |
|
This PR has the |
|
Could you help me here too, please Tio? |
yajo
approved these changes
Mar 13, 2024
| @api.model | ||
| def _name_search(self, name="", args=None, operator="ilike", limit=100): | ||
| """Allow searching by ref by default.""" | ||
| if name and operator in ["=", "ilike", "=ilike", "like", "=like"]: |
There was a problem hiding this comment.
This is faster:
Suggested change
| if name and operator in ["=", "ilike", "=ilike", "like", "=like"]: | |
| if name and operator in {"=", "ilike", "=ilike", "like", "=like"}: |
The search functionality has been improved to include the Partner Reference. This enhancement is achieved by inheriting the _name_search method to include the Partner Reference in the search domain. Additionally, tests have been added for this new inheritance.
…n Number The search functionality has been improved to include the VAT Identification Number. This enhancement is achieved by inheriting the _name_search method to include the VAT Identification Number in the search domain. Additionally, tests have been added for this new inheritance.
Since the class SavepointCase has been merged into TransactionCase, it has been replaced in the module tests.
CLaurelB
force-pushed
the
15.0-add_name_search_by_ref_and_vat-CLaurelB
branch
from
6ec69cd to
e753209
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 4a69cb5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search functionality has been improved to include the VAT
Identification Number and Partner Reference. This enhancement
is achieved by inheriting the _name_search method to include
the VAT Identification Number and Partner Reference in the
search domain.
Additionally, tests have been added for this new inheritance.