Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] update chained fields name in ir_exports_line and ir_filters tables #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented May 9, 2023

Cc @Tecnativa TT42912

Improve 'rename_fields' method to update changed field names in export profiles and domain fields. Domain fields are listed in 'openupgrade_framework' module of 'OCA/OpenUpgrade'. OCA/OpenUpgrade#3892

ping @pedrobaeza

@legalsylvain legalsylvain mentioned this pull request May 9, 2023
@legalsylvain
Copy link
Contributor

Thanks for you contribution.
For the time being, blocked by #321.

@ernestotejeda ernestotejeda force-pushed the imp-rename_fields-update-ir_exports_line branch 3 times, most recently from 10763f3 to e06e4a1 Compare May 11, 2023 17:11
@ernestotejeda ernestotejeda marked this pull request as ready for review May 11, 2023 17:12
@ernestotejeda
Copy link
Member Author

@pedrobaeza it is ready for review :)

@legalsylvain
Copy link
Contributor

Use fixed CI
/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force Tecnativa tmp-pr-319:imp-rename_fields-update-ir_exports_line failed with output:

remote: Permission to Tecnativa/openupgradelib.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Tecnativa/openupgradelib/': The requested URL returned error: 403

@ernestotejeda ernestotejeda force-pushed the imp-rename_fields-update-ir_exports_line branch from e06e4a1 to 729e0b5 Compare May 16, 2023 13:34
@ernestotejeda
Copy link
Member Author

Rebased to maste, thank you @legalsylvain

@ernestotejeda ernestotejeda force-pushed the imp-rename_fields-update-ir_exports_line branch 3 times, most recently from d6d9ffb to 71ae0f5 Compare May 26, 2023 13:26
@ernestotejeda ernestotejeda marked this pull request as draft May 26, 2023 13:26
@ernestotejeda ernestotejeda force-pushed the imp-rename_fields-update-ir_exports_line branch 2 times, most recently from 590695d to 3dbf266 Compare May 26, 2023 16:28
@ernestotejeda ernestotejeda marked this pull request as ready for review May 26, 2023 16:36
@ernestotejeda
Copy link
Member Author

@pedrobaeza it is ready for review now

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design question here : OCA/OpenUpgrade#3892 (review)

@ernestotejeda ernestotejeda force-pushed the imp-rename_fields-update-ir_exports_line branch from 3dbf266 to edbeb42 Compare June 6, 2023 15:39
@chienandalu chienandalu force-pushed the imp-rename_fields-update-ir_exports_line branch 2 times, most recently from 44ac580 to ed85fb5 Compare September 11, 2023 13:56
Improve rename_fields method to update changed field names
in export profiles and domain fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants