Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mgmtsystem: Update icon #565

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

SMaciasOSI
Copy link
Contributor

@bosd
Copy link

bosd commented Jan 12, 2024

How did you manage to create this V17 style icon?

@SMaciasOSI
Copy link
Contributor Author

@bosd Our graphic designer made it

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome indeed.

Could you update also the svg file?

Both png and svg need to be updated and kept in sync.

The svg one is used to be able to easily maintain it in the future

@SMaciasOSI
Copy link
Contributor Author

@ivantodorovich Done

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ looks really good

I would check the dimensions of the png image. 591 x 587 seems too large IMO.
I encourage you to check the dimensions in standard Odoo apps logos, and then use the same dimensions.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@max3903 max3903 changed the title [IMP] v17 style icon [IMP] mgmtsystem: Update icon Jan 18, 2024
@max3903 max3903 added this to the 17.0 milestone Jan 18, 2024
@max3903
Copy link
Member

max3903 commented Jan 18, 2024

/ocabot merge no-bump

@OCA-git-bot
Copy link
Contributor

Hi @max3903. Your command failed:

Invalid options for command merge: no.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@max3903
Copy link
Member

max3903 commented Jan 18, 2024

/ocabot merge bump

@OCA-git-bot
Copy link
Contributor

Hi @max3903. Your command failed:

Invalid options for command merge: bump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@max3903
Copy link
Member

max3903 commented Jan 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-565-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3a0a4e into OCA:17.0 Jan 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3a0a4e. Thanks a lot for contributing to OCA. ❤️

@max3903 max3903 deleted the 17.0-imp-v17-style-icon branch January 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants