Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oca-gen-addon-readme: delete pandoc installer #620

Merged
merged 1 commit into from
Jul 4, 2024
Merged

oca-gen-addon-readme: delete pandoc installer #620

merged 1 commit into from
Jul 4, 2024

Conversation

nilshamerlinck
Copy link
Contributor

@nilshamerlinck nilshamerlinck commented Jul 4, 2024 •
edited by sbidoul
Loading

  • when pandoc is not available in PATH, ensure_pandoc_installed downloads its installer in current directory and unpacks it
  • one might question that intrusive behavior; in our case we can consider it as beginner friendly
  • we just need to delete the installer to avoid polluting repos

fixes #619

pedrobaeza
pedrobaeza approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. It has been a total pain.

@nilshamerlinck nilshamerlinck mentioned this pull request Jul 4, 2024
Closed
@sbidoul
Copy link
Member

sbidoul commented Jul 4, 2024

Thanks!

@sbidoul sbidoul merged commit b2b2c72 into OCA:master Jul 4, 2024
7 checks passed
@sbidoul sbidoul mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pandoc-3.2-1-amd64.deb added by precommit hook
3 participants
@nilshamerlinck @sbidoul @pedrobaeza