-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] gen_addon_icon: generate cool icons with popular icon libs #491
base: master
Are you sure you want to change the base?
Conversation
Great stuff! Do we have SVG support? 🙏 |
Great stuff, would https://codepen.io/fheodoo/pen/XWNawZd help to make icons look and feel more like v 12 onward? |
Fantastic! |
Yeah, it's just a matter of adding an extra flag 😄 |
Well, that's been the base for this. With the first test, I was having issus with wkhtmltoimage rendering of css shadows and rounded borders, so for the moment I chose a simpler design |
2ee2b1f
to
dd08a89
Compare
https://spilymp.github.io/ibo/ |
dd08a89
to
290f5d6
Compare
Please rebase and fix conflicts. |
Works well, I manage to generate this icon using the script: https://github.com/akretion/vertical-abbey/blob/14-mig-stay/stay/static/description/icon.png
There is one small problem: the logo is not centered: it touches the right border. The option --icon-padding 15 that is mentioned in the example in the first message of this PR doesn't exist any more and I haven't found any replacement. Any idea how I could center the icon ? I don't have this problem with Fabrice's codepen. |
I confirm the problem, cf this other icon I just generated: https://github.com/akretion/vertical-abbey/blob/14-mig-mass/mass/static/description/icon.png |
Yes, the last thing I added was a way to allow some complexity so you could overlap icons, set colors, etc. with the param
|
@chienandalu Thanks for the tip! The icons are now centered! |
Is it possible to include: https://github.com/boydjd/FontCountry |
For my last icon generation, I used "font-size": "70px" to manage the size of the image inside the icon. The full command line I used was:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool Feature!
@chienandalu Can you fix the merge conflicts? |
It's abandoned on my side. Any supersed will be welcome ;) |
Generate the app icon easily from a variety of choices. Based on this codepen by Fabrice Hernion: https://twitter.com/fheodoo/status/1363598364638539776
Example of usage: