[16.0][MIG] l10n_ch_import_cresus #746
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9.0 doesn't have it
It seems the sample data I have received uses it
They appeared im my sample data.
not strictly necessary but nicer that way
maybe just disabling new/discard would be enough, but I found no way to do it simply
Same as the button, seems logical.
calling the inner function so the self.cr.rollback() part doesn't kick in, as the AccountingCresusImport itself didn't when this cursor was created. That's why I created _import_file originally, I must've forgotten to replace the call then.
It's heavy, but it's exhaustive and it allows me to gauge at a glance how future changes to the module I'll be making affect the output. (similar to 75d3935)
note: the patch to golden-output.txt amounts to reordering, so it's acceptable (similar to 602a617)
(similar to 31dc1a1)
happens when an error happens before the processing loop, e. g. in csv parsing.
Currently translated at 25.8% (8 of 31 strings) Translation: l10n-switzerland-10.0/l10n-switzerland-10.0-l10n_ch_import_cresus Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-10-0/l10n-switzerland-10-0-l10n_ch_import_cresus/it/
Currently translated at 25.8% (8 of 31 strings) Translation: l10n-switzerland-10.0/l10n-switzerland-10.0-l10n_ch_import_cresus Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-10-0/l10n-switzerland-10-0-l10n_ch_import_cresus/it/
Currently translated at 25.8% (8 of 31 strings) Translation: l10n-switzerland-10.0/l10n-switzerland-10.0-l10n_ch_import_cresus Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-10-0/l10n-switzerland-10-0-l10n_ch_import_cresus/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.