[16.0] Add module l10n_ch_credit_control_dunning_fees_qr_report #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
approved these changes
Sep 23, 2024
Comment on lines
+21
to
+24
| invoices = self.env["account.move"].browse(docids) | ||
| for invoice in invoices: | ||
| if invoice.id not in dunning_fees_qr_amounts: | ||
| continue |
There was a problem hiding this comment.
Suggested change
| invoices = self.env["account.move"].browse(docids) | |
| for invoice in invoices: | |
| if invoice.id not in dunning_fees_qr_amounts: | |
| continue | |
| invoices = self.env["account.move"].browse(list(dunning_fees_qr_amounts.keys())) | |
| for invoice in invoices: |
You know already the ones to browse no?
Comment on lines
+12
to
+17
| if self.id in qr_dunning_fees_amounts: | ||
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | ||
| ",", "\xa0" | ||
| ) | ||
| else: | ||
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") |
There was a problem hiding this comment.
Suggested change
| if self.id in qr_dunning_fees_amounts: | |
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | |
| ",", "\xa0" | |
| ) | |
| else: | |
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") | |
| if self.id in qr_dunning_fees_amounts: | |
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | |
| ",", "\xa0" | |
| ) | |
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") |
any comment to explain why this is needed?
l10n_ch_credit_control_dunning_fees_qr_report/models/credit_control_communication_report.py
Outdated
Show resolved
Hide resolved
| report_ref, data, res_ids=res_ids | ||
| ) | ||
|
|
||
| collected_streams = OrderedDict() |
There was a problem hiding this comment.
maybe move to a separate method like _pdf_prepare_streams_cc_dunning_fees?
|
@simahawk Out of moving class to its dedicated file, I would prefer keeping code as it to avoid any unforeseen issue since it's been working in production for a while. Also I'm not the original author, most of the code was from @ajaniszewska-dev , so I cannot necessarily answer all these questions. A test would be good yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module will ensure dunning fees are considered when generating swiss
QR-bill from credit control lines.