Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_ch_base_bank: Migration to 16.0 #724

Closed
wants to merge 138 commits into from
Closed

[16.0][MIG] l10n_ch_base_bank: Migration to 16.0 #724

wants to merge 138 commits into from

Conversation

BT-anieto
Copy link

No description provided.

nbessi and others added 30 commits June 11, 2024 13:39
@nbessi @BT-anieto
[IMP] refactoring module structure
05e9323
@nbessi @BT-anieto
[FIX] port of base bank
3102e11
@nbessi @BT-anieto
[REF] bvr report
4f736cc
@nbessi @BT-anieto
[REF] move from spli to bank"
b452084
@nbessi @BT-anieto
[FIX] non serializable type
baaf13f
@nbessi @BT-anieto
[FIX] default in sale workflow fo generated invoices
194a769
@nbessi @BT-anieto
[REFACTOR] bank dispertion
748bfd4
@nbessi @BT-anieto
[FIX] contributors list
c7418e6
@nbessi @BT-anieto
[FIX] encoding metadata
e140e6c
@nbessi @BT-anieto
[ADD] add post related field
07abaea
@nbessi @BT-anieto
[IMP] add notion of CCP on bank instead of having an account on res.p…
b6659a3 
…artner.bank.

The code is retro compatible and if you do not have a ccp on bank it will act as before
@nbessi @BT-anieto
[IMP] change version of addons + update changelog
9f6e64e
@nbessi @BT-anieto
[FIX] res.partner.bank view
5f28519
@nbessi @BT-anieto
[FIX] ccp related is read only
c2f1f44
@nbessi @BT-anieto
[FIX] blank line
9d22883
@nbessi @BT-anieto
[FIX] bank view city and zip where duplicated
35b6b12
@nbessi @BT-anieto
[FIX] hide ccp if the bic is the postfinance one
81f54f0
@nbessi @BT-anieto
[FIX] bank search and name get. Add a intelligent name search and add…
1df813e 
… city to name get
@nbessi @BT-anieto
[ADD] street on res.bank name_get and name_search
e8aedb0
@vrenaville @BT-anieto
[FIX]only bvr requiered bvr ref
f7a92f1
@jgrandguillaume @BT-anieto
[IMP] Add all translations .pot file in order to allow people to tran…
bfd8a77 
…slate module on LP
@guewen @BT-anieto
fix a bug when an account number is empty
7c0c32a
@nbessi @BT-anieto
Set all addons to uninstallable
47ebe23
@nbessi @BT-anieto
Rename all addons to xxx_unported
08633db
@PCatinean @BT-anieto
[ADD] Added l10n_ch_base_bank migrated to the new api
f9a582e
@nbessi @BT-anieto
Cleanup of l10n_ch_base_bank port
338e340
@nbessi @BT-anieto
Remove deprecated size
9e1b6c9
@nbessi @BT-anieto
Better variable name
6702327
@nbessi @BT-anieto
Renaming variables
553911b
@nbessi @BT-anieto
Better function call
b42954d
yvaucher and others added 17 commits June 11, 2024 13:50
@yvaucher @BT-anieto
Clearing do not have leading 0s
c2a1f2e
@yvaucher @BT-anieto
[REF] l10n_ch_postal onchanges
034e441 
Replace "Postal number" by "ISR"
Detect an ISR subscription number based on the leading digits 01 or 03
@yvaucher @BT-anieto
Document
90451ba
@yvaucher @BT-anieto
Signature change of _is_isr_ref
0bb8385
@yvaucher @BT-anieto
Adapt to odoo core change that removed _is_isr_ref
e4b40e4 
Follow the removal from here: odoo/odoo#53815
@yvaucher @BT-anieto
[TR] remove useless terms of invoice.py
86c32f7
@SimoneVagile @BT-anieto
[14.0][MIG] l10n_ch_base_bank
87b0e6e
@oca-travis @BT-anieto
[UPD] Update l10n_ch_base_bank.pot
057ebb7
@TDu @BT-anieto
[14.0][FIX] l10n_ch_base_bank
b1fa7e7 
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
@OCA-git-bot @BT-anieto
l10n_ch_base_bank 14.0.1.0.1
94eb975
@BT-anieto
[MIG] l10n_ch_account_tags: Migration to 14.0
8941fb9
@hailangvn @BT-anieto
[FIX] l10n_ch_base_bank: fix tests
5bbc42f
@OCA-git-bot @BT-anieto
l10n_ch_base_bank 14.0.1.0.2
86ddd05
@OCA-git-bot @BT-anieto
[UPD] README.rst
3a10ff2
@TDu @BT-anieto
[IMP] linting manual fix
0cfa92a
@mymage @BT-anieto
Translated using Weblate (Italian)
4f4237d 
Currently translated at 35.0% (7 of 20 strings)

Translation: l10n-switzerland-14.0/l10n-switzerland-14.0-l10n_ch_base_bank
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-14-0/l10n-switzerland-14-0-l10n_ch_base_bank/it/
@BT-anieto
[IMP] l10n_ch_base_bank: pre-commit stuff
6581dd8
@BT-anieto BT-anieto force-pushed the 16.0-mig-l10n_ch_base_bank branch 3 times, most recently from 38070b5 to d9945af Compare June 11, 2024 12:46
@BT-anieto BT-anieto mentioned this pull request Jun 11, 2024
Open
@davidwul
Copy link
Contributor

@BT-anieto
May I ask what's the purpose of this module?
base_bank is not needed anymore for pain_base, credit_transfer and direct_debit. Is this module needed elsewhere?

@BT-anieto
Copy link
Author

@davidwul Yes, of course! The aim for me was to migrate l10n_ch_pain_credit_transfer. Those are dependencies of the module. If we can remove the dependencies and leave the module as it is, for me it's fine :)

@davidwul
Copy link
Contributor

yes, see PR's here, #722
it's probably just barely ported, but it works without base_bank.
direct_debit is not ported, but it is in v14 #704 or maybe here if base_bank is not yet removed https://github.com/CompassionCH/l10n-switzerland

@BT-anieto
Copy link
Author

@davidwul The PR wrong name makes it difficult to follow. You should port module by module with the right commit names (as I did). If you change it, I can review your PRs and close mines

@BT-anieto
Copy link
Author

Closed because obsolete as stated here #686

@BT-anieto BT-anieto closed this Jun 12, 2024
@BT-anieto BT-anieto deleted the 16.0-mig-l10n_ch_base_bank branch June 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.