Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][17.0] l10n_ch_qr_no_amount: Migration to 17.0 #721

Merged
merged 5 commits into from
Jun 28, 2024
Merged

[MIG][17.0] l10n_ch_qr_no_amount: Migration to 17.0 #721

merged 5 commits into from
Jun 28, 2024

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented May 2, 2024 •
edited
Loading

@sonhd91 sonhd91 mentioned this pull request May 2, 2024
Open
2 tasks
TDu
TDu reviewed May 31, 2024
View reviewed changes
l10n_ch_qr_no_amount/report/swissqr_no_amount_report.py Outdated

@api.model
def _get_report_values(self, docids, data=None):
return super()._get_report_values(docids, data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually is this needed ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@TDu TDu self-requested a review May 31, 2024 10:13
@sonhd91 sonhd91 force-pushed the 17.0-mig-l10n_ch_qr_no_amount branch from fe1fa6b to 8d7a606 Compare June 28, 2024 03:13
@TDu TDu merged commit d1447ea into OCA:17.0 Jun 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@ivantodorovich ivantodorovich ivantodorovich left review comments

@yankinmax yankinmax yankinmax approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sonhd91 @OCA-git-bot @TDu @ivantodorovich @yankinmax @grindtildeath