Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_nl_partner_name: Migration to 16.0 #418

Merged
merged 27 commits into from
Oct 7, 2024
Merged

[16.0][MIG] l10n_nl_partner_name: Migration to 16.0 #418

merged 27 commits into from
Oct 7, 2024

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jul 22, 2024

No description provided.

hbrunn and others added 16 commits July 22, 2024 07:59
@hbrunn
[ADD] l10n_nl_partner_name, l10n_nl_partner_salutation
9392ede
@hbrunn
[FIX] show empty string if lastname is unset
faede2d
@hbrunn
[UPD] make it work with latest partner-contact
cd561c6
@hbrunn
[FIX] flake8
ea41c7d
@hbrunn
[ADD] tests
939c63e
@sbidoul @hbrunn
[UPD] prefix versions with 8.0
b6e0801
@hbrunn
[FIX] linting
f83297c
@hbrunn
[MIG] Migrates l10n_nl_partner_name
524cd25 
from 8.0 to 10.0

[MIG] Migrates l10n_nl_partner_salutation from 8.0 to 10.0

Adding a commiter, changing the format of the licence comment, removing deprecated Char init variable

[FIX] Sort version of licencing, removing VIM comments, changing __openerp__ to __manifest__

[FIX] Adding tests to increase code coverage

[FIX] Replaces api.one with api.multi and inserting api.model

[FIX] Adds newlines on the xmls, adds licence on manifest, changes name of compute methods

[FIX] Creates the res_partner_title_sir in the module instead on the base module
@sbidoul @hbrunn
[FIX] version number in l10n_nl_partner_name
c9d47ff
@sbidoul @hbrunn
remove obsolete .pot files [ci skip]
ce664ec
@oca-travis @hbrunn
[UPD] Update l10n_nl_partner_name.pot
4681ba8
@hbrunn
[10.0] l10n_nl_partner_name improvements (OCA#128)
f6e7d36 
* [DEL] obsolete manifest

* [IMP] allow to fill in names in a more natural way
@oca-travis @hbrunn
[UPD] Update l10n_nl_partner_name.pot
12a3e65
@hbrunn
[MIG] l10n_nl_partner_name: Migration to 11.0
cab45b7
@oca-travis @hbrunn
[UPD] Update l10n_nl_partner_name.pot
b49eef4
@oca-transbot @hbrunn
Update translation files
7a07af8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-netherlands-11.0/l10n-netherlands-11.0-l10n_nl_partner_name
Translate-URL: https://translation.odoo-community.org/projects/l10n-netherlands-11-0/l10n-netherlands-11-0-l10n_nl_partner_name/
@hbrunn hbrunn force-pushed the 16.0-mig-l10n_nl_partner_name branch 2 times, most recently from 016869d to 8d2be30 Compare July 22, 2024 16:09
gjotten
gjotten reviewed Jul 24, 2024
View reviewed changes
l10n_nl_partner_name/models/res_partner.py Outdated
"""Extend res.partner with extra fields for Dutch names."""

_inherit = "res.partner"
_l10n_nl_partner_name_infixes = ("van", "der", "den", "op", "ter", "de", "v/d")
Copy link
Contributor

@gjotten gjotten Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbrunn just curious since I've never used this module before personally, but if we use non-defined infixes like d', 't or te, the helper method below is not going to split names up correctly, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly. Any other ones I should add?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wiki page contains a curated summary, as well as a a link to a 12-page list provided by the Interior Ministry.

Looks like the latter should be handled in a reference file if push comes to shove 🙁

Copy link
Member Author

@hbrunn hbrunn Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the easy way out, added your proposals to the default and made the whole thing configurable. Please review the readme part about that for non-nerd compatibility

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme explanation LGTM

@bosd
Copy link
Contributor

bosd commented Oct 1, 2024

@hbrunn Can you please retrigger runboat creation??

hbrunn and others added 10 commits October 1, 2024 12:55
@hbrunn
[MIG] [12.0] l10n_nl_partner_name
407dc63
@NL66278 @hbrunn
[IMP] l10n_nl_partner_name: black, isort, prettier
84d1c03
@NL66278 @hbrunn
[MIG] l10n_nl_partner_name: Migration to 13.0
5cfdc3b
@NL66278 @hbrunn
[WIP] partner_name: update guess names script
1c9ec9e
@hbrunn
[UPD] Update l10n_nl_partner_name.pot
6185d21
@weblate @hbrunn
Update translation files
208a100 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-netherlands-13.0/l10n-netherlands-13.0-l10n_nl_partner_name
Translate-URL: https://translation.odoo-community.org/projects/l10n-netherlands-13-0/l10n-netherlands-13-0-l10n_nl_partner_name/
@hbrunn
[IMP] l10n_nl_partner_name: pre-commit stuff
e1b564a
@hbrunn
[MIG] l10n_nl_partner_name: Migration to 16.0
257ed9c
@hbrunn
[FIX] l10n_nl_oin: make test compatible with l10n_nl_partner_name
ff42b33
@hbrunn
[FIX] l10n_nl_bsn: make test compatible with l10n_nl_partner_name
f131cf2
@hbrunn hbrunn force-pushed the 16.0-mig-l10n_nl_partner_name branch from 1ace91c to 31b33a0 Compare October 1, 2024 10:55
@hbrunn
Copy link
Member Author

hbrunn commented Oct 1, 2024

done

gjotten
gjotten approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@gjotten gjotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally, @NL66278 probably worth a technical review as well.

NL66278
NL66278 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Oct 7, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-418-by-NL66278-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d41dec into OCA:16.0 Oct 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 76c12df. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjotten gjotten gjotten approved these changes

@NL66278 NL66278 NL66278 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hbrunn @bosd @OCA-git-bot @NL66278 @gjotten @sbidoul @oca-travis @oca-transbot @weblate