[16.0][FIX] *+xaf_auditfile_export: use correct company in name #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the export record is created with the current company in the environment (self.env.company), but the default company for the user (self.env.user.company_id) is applied to the name generated. This can and will lead to mismatches. This fix will consistently use self.env.company.
astirpe
approved these changes
Oct 11, 2023
thomaspaulb
approved these changes
Oct 12, 2023
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c380adf. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the export record is created with the current company in the environment (self.env.company), but the default company for the user (self.env.user.company_id) is applied to the name generated. This can and will lead to mismatches.
This fix will consistently use self.env.company.
The same change was already merged in 14.0.