[16.0][MIG] l10n_nl_account_tax_unece

[astirpe]

Depends on OCA/community-data-files#172

[NL66278]

/ocabot migration l10n_nl_account_tax_unece

[bosd]

LGTM 👍

[astirpe]

Rebased. Also changed license from AGPL to LGPL, so this PR now depends on OCA/community-data-files#172

[thomaspaulb]

Hm, the test fails with

2023-10-31 11:15:43,571 268 ERROR odoo odoo.addons.l10n_nl_account_tax_unece.tests.test_nl_account_tax_unece: FAIL: TestNlAccountTaxUnece.test_existing_coa_update
Traceback (most recent call last):
  File "/__w/l10n-netherlands/l10n-netherlands/l10n_nl_account_tax_unece/tests/test_nl_account_tax_unece.py", line 63, in test_existing_coa_update
    self.assertTrue(tax.unece_type_id.id == unece_type_id)
AssertionError: False is not true

[astirpe]

Seems the tests are failing after odoo/odoo@b63f21b since a new tax template "btw_X0_ABC_levering" was added in l10n_nl.

[bosd]

Please have a look at this PR, #404 to update the category's.
Maybe we can incorporate that, before the migration to V16.

[astirpe]

@bosd yes indeed it could be fixed all-in-once. I will include your fixes but unfortunately I'm not able to verify myself whether they are correct or not.

[bosd]

Sorry, I forgot about that PR. Continued working on it..
Now ready for 14 and 15 branch.
When you include it here, it might fix the tests 🤔

[NL66278]

@astirpe So these are the two test failures, bot related to COA:

2023-10-31T11:15:43.5728662Z 2023-10-31 11:15:43,571 268 �[1;31m�[1;49mERROR�[0m odoo odoo.addons.l10n_nl_account_tax_unece.tests.test_nl_account_tax_unece: FAIL: TestNlAccountTaxUnece.test_existing_coa_update
2023-10-31T11:15:43.5730016Z Traceback (most recent call last):
2023-10-31T11:15:43.5731325Z   File "/__w/l10n-netherlands/l10n-netherlands/l10n_nl_account_tax_unece/tests/test_nl_account_tax_unece.py", line 63, in test_existing_coa_update
2023-10-31T11:15:43.5732615Z     self.assertTrue(tax.unece_type_id.id == unece_type_id)
2023-10-31T11:15:43.5733237Z AssertionError: False is not true
2023-10-31T11:15:43.5733662Z 

---

2023-10-31T11:15:47.0571298Z 2023-10-31 11:15:47,051 268 �[1;31m�[1;49mERROR�[0m odoo odoo.addons.l10n_nl_account_tax_unece.tests.test_nl_account_tax_unece: FAIL: TestNlAccountTaxUnece.test_load_coa
2023-10-31T11:15:47.0572735Z Traceback (most recent call last):
2023-10-31T11:15:47.0574052Z   File "/__w/l10n-netherlands/l10n-netherlands/l10n_nl_account_tax_unece/tests/test_nl_account_tax_unece.py", line 41, in test_load_coa
2023-10-31T11:15:47.0575279Z     self.assertTrue(tax.unece_type_id.id == unece_type_id)
2023-10-31T11:15:47.0575898Z AssertionError: False is not true
2023-10-31T11:15:47.0576306Z  

Instead of assertTrue and then an equal comparison, maybe better do an assertEqual. Then on failure you will have both values in the log, making it easier to get to the root of the problem.

[hbrunn]

superseded by #417