[11.0][IMP] l10n_nl_postcodeapi: improved code and compatibility #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NL66278! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
NL66278
force-pushed
the
11.0-fix-ln10n_nl_postcodeapi
branch
4 times, most recently
from
293cbd0
to
dc888e6
Compare
NL66278
force-pushed
the
11.0-fix-ln10n_nl_postcodeapi
branch
from
dc888e6
to
fb060bd
Compare
thomaspaulb
approved these changes
Sep 27, 2021
|
@lfreeke Your functional review here maybe? |
|
Closed in favor of this: #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now depend on l10n_nl_country_states for better compatibility and prevent incompatible changes to res_country_state.code contents.
Also the code has been streamlined, and it is hoped it will be compatible with the addition of the l10n_nl_letsencrypt_transip_nl module #262.