fix issue #3884, add test and update CONTRIBUTORS

OCA · Jan 20, 2025 · f5a7d14 · f5a7d14
1 parent cf850e8
commit f5a7d14
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 3 deletions.
diff --git a/l10n_it_fatturapa_in/README.rst b/l10n_it_fatturapa_in/README.rst
@@ -178,7 +178,7 @@ Contributors
 * Giovanni Serra <[email protected]>
 * Gianmarco Conte <[email protected]>
 * Marco Colombo <https://github.com/TheMule71>
-
+* Salvo Rapisarda <https://github.com/salvorapi>
 * `Aion Tech <https://aiontech.company/>`_:
 
   * Simone Rubino <[email protected]>

diff --git a/l10n_it_fatturapa_in/readme/CONTRIBUTORS.rst b/l10n_it_fatturapa_in/readme/CONTRIBUTORS.rst
@@ -5,7 +5,7 @@
 * Giovanni Serra <[email protected]>
 * Gianmarco Conte <[email protected]>
 * Marco Colombo <https://github.com/TheMule71>
-
+* Salvo Rapisarda <https://github.com/salvorapi>
 * `Aion Tech <https://aiontech.company/>`_:
 
   * Simone Rubino <[email protected]>
diff --git a/l10n_it_fatturapa_in/static/description/index.html b/l10n_it_fatturapa_in/static/description/index.html
@@ -500,6 +500,7 @@ <h2><a class="toc-backref" href="#toc-entry-8">Contributors</a></h2>
 <li>Giovanni Serra &lt;<a class="reference external" href="mailto:giovanni&#64;gslab.it">giovanni&#64;gslab.it</a>&gt;</li>
 <li>Gianmarco Conte &lt;<a class="reference external" href="mailto:gconte&#64;dinamicheaziendali.it">gconte&#64;dinamicheaziendali.it</a>&gt;</li>
 <li>Marco Colombo &lt;<a class="reference external" href="https://github.com/TheMule71">https://github.com/TheMule71</a>&gt;</li>
+<li>Salvo Rapisarda &lt;<a class="reference external" href="https://github.com/salvorapi">https://github.com/salvorapi</a>&gt;</li>
 <li><a class="reference external" href="https://aiontech.company/">Aion Tech</a>:<ul>
 <li>Simone Rubino &lt;<a class="reference external" href="mailto:simone.rubino&#64;aion-tech.it">simone.rubino&#64;aion-tech.it</a>&gt;</li>
 </ul>

diff --git a/l10n_it_ricevute_bancarie/tests/test_riba.py b/l10n_it_ricevute_bancarie/tests/test_riba.py
@@ -375,6 +375,28 @@ def test_unsolved_riba(self):
         wiz_accreditation.create_move()
         self.assertEqual(riba_list.state, "accredited")
 
+        # credit wizard with skip
+        credit_wizard = (
+            self.env["riba.accreditation"]
+            .with_context(
+                {
+                    "active_model": "riba.distinta",
+                    "active_ids": [riba_list_id],
+                    "active_id": riba_list_id,
+                }
+            )
+            .create(
+                {
+                    "bank_amount": 95,
+                    "expense_amount": 5,
+                }
+            )
+        )
+        credit_wizard.skip()
+        self.assertEqual(riba_list.state, "accredited")
+
+        self.assertEqual(riba_list.line_ids[0].state, "accredited")
+
         # past due wizard
         wiz_unsolved = (
             self.env["riba.unsolved"]

diff --git a/l10n_it_ricevute_bancarie/wizard/wizard_accreditation.py b/l10n_it_ricevute_bancarie/wizard/wizard_accreditation.py
@@ -76,7 +76,9 @@ def skip(self):
         active_id = self.env.context.get("active_id") or False
         if not active_id:
             raise UserError(_("No active ID found."))
-        self.env["riba.distinta"].browse(active_id).state = "accredited"
+        riba_distinta = self.env["riba.distinta"].browse(active_id)
+        riba_distinta.state = "accredited"
+        riba_distinta.line_ids.state = "accredited"
         return {"type": "ir.actions.act_window_close"}
 
     def create_move(self):