Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_announcement: Migration to version 17.0 #1390

Merged
merged 7 commits into from
Sep 6, 2024
Merged

[17.0][MIG] hr_announcement: Migration to version 17.0 #1390

merged 7 commits into from
Sep 6, 2024

Conversation

juanjosesegui-tecnativa
Copy link
Contributor

@juanjosesegui-tecnativa juanjosesegui-tecnativa commented Sep 2, 2024 •
edited
Loading

@Tecnativa TT50061

@pedrobaeza
Copy link
Member

/ocabot migration hr_announcement

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 2, 2024
Open
20 tasks
@pedrobaeza
Copy link
Member

Add the temporary dependency with https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

chienandalu
chienandalu reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and code review 👍

Only 👇

test-requirements.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should go in a separate commit so you can drop it easily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct with the new commit?

@chienandalu
Copy link
Member

Yes :) now let's wait for the main one to be merged :)

@victoralmau
Copy link
Member

Can you rebase to review it (announcement is already merged OCA/server-ux#935)?

@juanjosesegui-tecnativa
Copy link
Contributor Author

Can you rebase to review it (announcement is already merged OCA/server-ux#935)?

Hi @victoralmau, it's done. Did I do it correctly?

chienandalu
chienandalu approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1390-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 89c401e into OCA:17.0 Sep 6, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5424460. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-hr_announcement branch September 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@juanjosesegui-tecnativa @pedrobaeza @chienandalu @victoralmau @OCA-git-bot @pilarvargas-tecnativa @mymage @Ivorra78