[14.0][FIX] hr_employee_firstname and hr_employee_lastnames #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e should not modify the firstname and lastname column
…e should not modify firstname lastname and lastname2 fields
apineux
approved these changes
Sep 27, 2023
gurneyalex
approved these changes
Nov 7, 2023
jdoutreloux
approved these changes
Nov 7, 2023
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unexpected behavior when importing a file updating employees.
If we import the column employee name while keeping the same name, the method _prepare_vals_on_write_firstname_lastname split again the name into firstname, lastname and lastname2. But the result may be different from what is present in db
I added a unit test that failed if we don't use the correction for both modules