Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] hr_employee_calendar_planning: Set calendar_ids default value to cover all use cases #1263

Merged
merged 2 commits into from
Jul 4, 2023
Merged

[13.0][IMP] hr_employee_calendar_planning: Set calendar_ids default value to cover all use cases #1263

merged 2 commits into from
Jul 4, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jun 29, 2023 •
edited
Loading

Set calendar_ids default value to cover all use cases.

Steps to reproduce the error (before):

  • Go to Recruitment > Apllications and enter one of them.
  • Click on the "Create employee" button and confirm.

An error is displayed when trying to create the employee because there is no calendar defined.

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT44093

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

I don't think injecting specific sources is the right patch. Instead, a default should exist for covering all cases.

@victoralmau victoralmau force-pushed the 13.0-fix-hr_employee_calendar_planning-TT44093 branch from c654097 to 94ed880 Compare June 30, 2023 06:22
@victoralmau victoralmau changed the title [13.0][IMP] hr_employee_calendar_planning: Set calendars if created from an hr job to avoid error [13.0][IMP] hr_employee_calendar_planning: Set calendar_ids default value to cover all use cases Jun 30, 2023
@victoralmau victoralmau force-pushed the 13.0-fix-hr_employee_calendar_planning-TT44093 branch from 94ed880 to 546c87d Compare June 30, 2023 06:24
@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 30, 2023
@pedrobaeza
Copy link
Member

With this you can remove also the _synchronize_user code, isn't it?

@victoralmau victoralmau force-pushed the 13.0-fix-hr_employee_calendar_planning-TT44093 branch 3 times, most recently from 0b9966e to 81c053e Compare June 30, 2023 07:07
@victoralmau
Copy link
Member Author

Changes done and test fixed

@victoralmau victoralmau force-pushed the 13.0-fix-hr_employee_calendar_planning-TT44093 branch from 81c053e to 372b3eb Compare July 3, 2023 06:58
@victoralmau victoralmau force-pushed the 13.0-fix-hr_employee_calendar_planning-TT44093 branch from c8dfe45 to 045dde5 Compare July 4, 2023 06:14
@victoralmau
Copy link
Member Author

Changes done.

pedrobaeza
pedrobaeza approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1263-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dbdd084 into OCA:13.0 Jul 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d857c71. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @OCA-git-bot @pedrobaeza @chienandalu