Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][IMP] hr_employee_calendar_planning: set calendar_ids from Create employee button from user #1259

Conversation

victoralmau
Copy link
Member

Backport from 14.0:

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT44093

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 27, 2023
@victoralmau victoralmau force-pushed the 13.0-imp-hr_employee_calendar_planning-issue-1163 branch from 46f4a7f to c1b5258 Compare June 27, 2023 07:06
victoralmau and others added 4 commits June 27, 2023 09:09
We should only fill the calendar with sync_user if and only if you don't have one

Sync user is used also when we modify the user of an employee
@victoralmau victoralmau force-pushed the 13.0-imp-hr_employee_calendar_planning-issue-1163 branch from c1b5258 to ba30d53 Compare June 27, 2023 07:12
@victoralmau
Copy link
Member Author

Ping @chienandalu

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1259-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0228154 into OCA:13.0 Jun 29, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 671d17a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants