Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_employee_document: Migration to 16.0. #1181

Merged
merged 18 commits into from
Aug 23, 2023
Merged

[16.0][MIG] hr_employee_document: Migration to 16.0. #1181

merged 18 commits into from
Aug 23, 2023

Conversation

BT-anieto
Copy link
Contributor

No description provided.

@BT-anieto
Copy link
Contributor Author

@pedrobaeza Created PR for hr_employee_document

@BT-anieto BT-anieto mentioned this pull request Dec 27, 2022
Open
24 tasks
@pedrobaeza
Copy link
Member

/ocabot migration hr_employee_document

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 27, 2022
@luistorresm
Copy link
Contributor

Hello @BT-anieto

Please apply this task to your MR: (You can see this here)

Squash administrative commits (if any) with the previous commit for reducing commit noise. They are named as "[UPD] README.rst", "[UPD] Update $MODULE.pot", "Update translation files" and similar names, and comes from OCA-git-bot, oca-travis or oca-transbot. IMPORTANT: Don't squash legit translation commits, authored by their translators, with the message "Translated using Weblate (...)".

@github-actions
Copy link

github-actions bot commented May 7, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 7, 2023
@AlbertoNieto44
Copy link

@luistorresm Hi Luis. Could you take a look at this PR?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 14, 2023
@BT-anieto
Copy link
Contributor Author

Why is it always building?

@victoralmau
Copy link
Member

Please, add #1271 to commit history.

@BT-anieto
Copy link
Contributor Author

@victoralmau I'll do it asap

alexey-pelykh and others added 12 commits August 23, 2023 10:31
@alexey-pelykh @BT-anieto
[12.0][ADD] hr_employee_document: various documents attached to the e…
3faf15e 
…mployee profile

[UPD] Update hr_employee_document.pot

[ADD] icon.png
@BT-anieto
Added translation using Weblate (French)
69d706b
@badbole @BT-anieto
Added translation using Weblate (Croatian)
06d6ec2
@robinkeunen @BT-anieto
[12.0][FIX] hr_employee_document: google_drive_link invisible
d3e8900 
Replacing google drive link in view by nothing, that is deleting,
breaks the view inheritance.
Making it invisible instead.

hr_employee_document 12.0.1.0.1
@alexey-pelykh @BT-anieto
[IMP] hr_employee_document: add attachment preview
916e9f1 
hr_employee_document 12.0.1.1.0
@newtratip @BT-anieto
[IMP] hr_employee_document: black, isort, prettier
b971f91
@newtratip @BT-anieto
[MIG] hr_employee_document: Migration to 13.0
cbb739b 
[UPD] Update hr_employee_document.pot
@alexey-pelykh @BT-anieto
[UPD] Brainbean Apps => CorporateHub
1db98e7 
[UPD] README.rst
@victoralmau @BT-anieto
[IMP] hr_employee_document: Add documents button in user profile
0db4a5a 
[UPD] Update hr_employee_document.pot

[UPD] README.rst

hr_employee_document 13.0.2.0.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-13.0/hr-13.0-hr_employee_document
Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_employee_document/
@victoralmau @BT-anieto
[IMP] hr_employee_document: Add security rule to allow user without e…
c6c3fea 
…mployee groups can access to attachments related to own employee

[UPD] README.rst

hr_employee_document 13.0.3.0.0
@victoralmau @BT-anieto
[IMP] hr_employee_document: black, isort, prettier
0d097f6
@victoralmau @BT-anieto
[MIG] hr_employee_document: Migration to 14.0
c3aaf99 
TT37024

[UPD] Update hr_employee_document.pot

[UPD] README.rst
victoralmau and others added 6 commits August 23, 2023 10:33
@victoralmau @BT-anieto
[MIG] hr_employee_document: Migration to 15.0
8a68625 
TT40359
@mymage @BT-anieto
Added translation using Weblate (Italian)
d0f2ff8
@victoralmau @BT-anieto
Added translation using Weblate (Spanish)
d371324
@victoralmau @BT-anieto
[FIX] hr_employee_document: Remove record rules from hr.employee to a…
3294b8a 
…void side effects.

The purpose of this module is to allow a basic user (without hr permissions) to view
the attachments related to his employee (hr.employee).

By default a basic user cannot access to hr.employee model and therefore
cannot see the attachments (ir.attachment) linked to it.

This change overrides some things to allow the user's employee attachments to be displayed.

TT44536
@BT-anieto
[IMP] hr_employee_document: pre-commit stuff
9c299ec
@BT-anieto
[MIG] hr_employee_document: Migration to 16.0
ba9c3cc
@BT-anieto BT-anieto force-pushed the 16.0-mig-hr_employee_document branch from c7e7e5e to ba9c3cc Compare August 23, 2023 08:38
@BT-anieto
Copy link
Contributor Author

@victoralmau Done!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

victoralmau
victoralmau approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1181-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3701bbb into OCA:16.0 Aug 23, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at efca073. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@luistorresm luistorresm luistorresm approved these changes

@BT-nfrancisco BT-nfrancisco BT-nfrancisco approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.