[14.0][IMP] hr_expense_invoice: prepare invoice values #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrobaeza, Can you review please? |
pedrobaeza
approved these changes
Aug 14, 2024
marcelsavegnago
approved these changes
Aug 14, 2024
rvalyi
approved these changes
Aug 16, 2024
mileo
approved these changes
Aug 16, 2024
mileo
suggested changes
Aug 16, 2024
kaynnan
force-pushed
the
14.0-imp-hr_expense_invoice
branch
from
fa4351f to
557242d
Compare
Change implemented. Thank you for the suggestion, @mileo. |
mileo
approved these changes
Aug 16, 2024
rvalyi
approved these changes
Aug 16, 2024
|
/ocabot merge patch |
|
@pedrobaeza Do I need to do a rebase for the merge to occur? Apparently the bot didn't return something |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 66db007. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcelsavegnago @douglascstd @WesleyOliveira98
The purpose of this PR is to separate the invoice values for use in a _prepare method. In cases where modifications are made to specific move_line only, it would be necessary to rewrite a significant amount of code. Therefore, using _prepare would facilitate this process.