[16.0][FIX] hr_expense_invoice: Incorrect data and check when creating vendor bill from expense

hr_expense_invoice/models/account_move.py

@@ -19,8 +19,13 @@ class AccountMove(models.Model):
         "transfer journal entry",
     )
 
-    @api.constrains("amount_total")
-    def _check_expense_ids(self):
+    def write(self, vals):
+        # Check if the amount of the invoice linked to an invoice is different
+        # Done here in the write instead of a Python constraint as the computed field
+        # amount_total is not yet updated on that moment
+        res = super().write(vals)
+        if self.env.context.get("skip_account_move_synchronization"):
+            return res
         DecimalPrecision = self.env["decimal.precision"]
         precision = DecimalPrecision.precision_get("Product Price")
         for move in self.filtered("expense_ids"):
@@ -32,6 +37,7 @@ def _check_expense_ids(self):
                         "linked to this invoice."
                     )
                 )
+        return res
 
     def action_view_expense(self):
         self.ensure_one()

hr_expense_invoice/models/hr_expense.py

@@ -36,7 +36,7 @@ def _prepare_invoice_values(self):
                 {
                     "product_id": self.product_id.id,
                     "name": self.name,
-                    "price_unit": self.unit_amount or self.total_amount,
+                    "price_unit": self.untaxed_amount,
                     "quantity": self.quantity,
                     "account_id": self.account_id.id,
                     "analytic_distribution": self.analytic_distribution,
@@ -126,6 +126,8 @@ def action_expense_create_invoice(self):
         )
         for attachment in attachments:
             attachment.copy({"res_model": invoice._name, "res_id": invoice.id})
+        # Normalize data in the expense for avoiding mismatchings. Examples: the tax
+        # reported is not correct, there's more than one concept, etc...
         self.write(
             {
                 "invoice_id": invoice.id,