Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [IMP] helpdesk_mgmt_project: Add groups to project/helpdesk fields #626

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[16.0] [IMP] helpdesk_mgmt_project: Add groups to project/helpdesk fields #626

merged 2 commits into from
Sep 17, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Sep 16, 2024 •
edited
Loading

Changes done:

  • Add groups="project.group_project_user" to helpdesk fields
  • Add groups="helpdesk_mgmt.group_helpdesk_user_own" to project fields

@Tecnativa

@victoralmau victoralmau marked this pull request as ready for review September 16, 2024 14:37
@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 16, 2024
dalonsod
dalonsod approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review 👍

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-626-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d664c46 into OCA:16.0 Sep 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 34dacfd. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-helpdesk_mgmt_project-misc_fields branch September 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @dalonsod