Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] helpdesk_mgmt_timesheet allow_timesheet accessible from all user #625

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[14.0][FIX] helpdesk_mgmt_timesheet allow_timesheet accessible from all user #625

merged 1 commit into from
Sep 21, 2024

Conversation

sergiocorato
Copy link

No description provided.

@sergiocorato sergiocorato mentioned this pull request Sep 16, 2024
Open
2 tasks
kenayagi
kenayagi approved these changes Sep 16, 2024
View reviewed changes
Copy link

@kenayagi kenayagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

dalonsod
dalonsod approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a cosmetic change, please fix typo in commit & PR titles (missing colon, move [FIX] helpdesk_mgmt_timesheet allow_timesheet... to [FIX] helpdesk_mgmt_timesheet: allow_timesheet...

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 18, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-625-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 85fdc0f into OCA:14.0 Sep 21, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a80e04. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenayagi kenayagi kenayagi approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@dalonsod dalonsod dalonsod approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sergiocorato @OCA-git-bot @kenayagi @pedrobaeza @dalonsod