Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] helpdesk_mgmt: use company of team on tickets when team is defined #557

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[16.0] [FIX] helpdesk_mgmt: use company of team on tickets when team is defined #557

merged 1 commit into from
Apr 9, 2024

Conversation

ByteMeAsap
Copy link
Contributor

Fixes #543

@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-helpdesk_mgmt branch 3 times, most recently from d9dc98e to 0459703 Compare April 3, 2024 11:41
flotho
flotho suggested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thanks for the contribution.
Code revie OK
Yet, the commit name are not correct nor the issue nme.
please adapt following https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@ByteMeAsap ByteMeAsap changed the title Fixes issue of wrong company being assigned to helpdesk tickets [16.0] [FIX] helpdesk_mgmt: use company of team on tickets when team is defined Apr 4, 2024
@ByteMeAsap
Copy link
Contributor Author

Hi, thanks for the contribution. Code revie OK Yet, the commit name are not correct nor the issue nme. please adapt following https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@flotho ,updated the commit and PR name

@ByteMeAsap ByteMeAsap requested a review from flotho April 5, 2024 12:01
@Jan-Onestein
Copy link

Works on this end, thank a lot @ByteMeAsap !!!
Please merge asap @flotho !!
@pedrobaeza can you do something from your end ?

Jan-Onestein
Jan-Onestein approved these changes Apr 9, 2024
View reviewed changes
Copy link

@Jan-Onestein Jan-Onestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on multicomp setup like intenden now!!!
Thanks @ByteMeAsap !!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 9, 2024
pedrobaeza
pedrobaeza approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-557-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f6a4ab0 into OCA:16.0 Apr 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at be5e951. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jul 10, 2024
Closed
@ByteMeAsap ByteMeAsap mentioned this pull request Sep 5, 2024
Closed
@eLBati
Copy link
Member

eLBati commented Sep 5, 2024

Porting to v15 with #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan-Onestein Jan-Onestein Jan-Onestein approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

wrong company assignment on ticket creation
6 participants
@ByteMeAsap @Jan-Onestein @OCA-git-bot @eLBati @flotho @pedrobaeza