[14.0][ADD] helpdesk_mgmt_timesheet: add optional ticket field in view #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoisRForgeFlow
approved these changes
Jun 29, 2023
dalonsod
suggested changes
Jun 29, 2023
| @@ -261,4 +261,14 @@ | |||
| </field> | |||
| </field> | |||
| </record> | |||
| <record id="view_task_form2_inherited" model="ir.ui.view"> | |||
There was a problem hiding this comment.
This view should be placed in its own project.task xml file.
Also, not tested and not sure, this could lead to security issues, when user is not allowed to Helpdesk app. Could you check?
There was a problem hiding this comment.
Made the following changes:
- moved the view to another xml file related with project.task.
- added a group restriction to helpdesk user so that only users in that group can view the field.
@dalonsod
SergiCForgeFlow
force-pushed
the
14.0-add-helpdesk_mgmt_timesheet
branch
from
8fc0fbd
to
88da8c6
Compare
|
This PR has the |
|
@pedrobaeza good to merge? |
pedrobaeza
requested changes
Jul 10, 2023
SergiCForgeFlow
force-pushed
the
14.0-add-helpdesk_mgmt_timesheet
branch
from
88da8c6
to
fa5010a
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 100f6ca. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional ticket field in Project Task timesheets tree view.