Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] website_sale_checkout_skip_payment: Migration to version 17.0 #997

Conversation

pilarvargas-tecnativa
Copy link
Contributor

Supersedes to #962

cc @Tecnativa TT51969

@chienandalu @CarlosRoca13 please review

sergio-teruel and others added 30 commits November 12, 2024 13:33
OCA Transbot updated translations from Transifex
…ut confirmation step when partner is has skip payment flag
Currently translated at 25.0% (2 of 8 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/it/
Currently translated at 87.5% (7 of 8 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/es/
Currently translated at 33.3% (5 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/nl/
Currently translated at 100.0% (15 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/ca/
Currently translated at 100.0% (15 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/es/
…ttons

With this changes the 'Process Checkout' button change to 'Confirm' when the partner has selected the option skip_website_checkout_payment. Furthermore, the button text 'Confirm Order' has been changed to 'Confirm'.

TT29736
… user

When the client is a public user we got an error, because the request.session.uid is None and the value of the field checkout_skip_payment is not computed.

As we want to compute this field always,the condition is removed to avoid the possible error.

TT29736
Currently translated at 100.0% (17 of 17 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_checkout_skip_payment/es_AR/
…n is not authenticated

[FIX] website_sale_checkout_skip_payment: CacheMiss error when session is not authenticated
Currently translated at 94.1% (16 of 17 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_checkout_skip_payment/pt/
Currently translated at 11.7% (2 of 17 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_checkout_skip_payment/it/
Alert message in the payment section of the web payment gateway so it
is convenient for this module to hide this message when
skip_website_checkout_payment is enabled.

Detected on Odoo 14.0  OCA/pull/752
remi-filament and others added 10 commits November 12, 2024 13:33
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/fr/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/pt_BR/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/sv/
When an order is confirmed and goes to the path ‘/shop/confirmation’,
the driver method involved is ‘shop_payment_confirmation’ from websitesale.
With the migration, the wrong method was involved as it was a portal
method and its path is ‘/payment/confirmation’, which has nothing to
do with the confirmation of an order.

TT50360
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_sale_checkout_skip_payment-continue branch from 391a4dd to 3f63db0 Compare December 18, 2024 11:40
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now :) test and code review 👍

@pilarvargas-tecnativa
Copy link
Contributor Author

ping @CarlosRoca13

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 4 the work :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration website_sale_checkout_skip_payment
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 10, 2025
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-997-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 10, 2025
27 tasks
@OCA-git-bot OCA-git-bot merged commit 5bd07b3 into OCA:17.0 Jan 10, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aba7232. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-website_sale_checkout_skip_payment-continue branch January 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.