Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] website_sale_invoice_address: displayed billing address #886

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] website_sale_invoice_address: displayed billing address #886

wants to merge 1 commit into from

Conversation

danielduqma
Copy link

This PR follows #748 (for 14.0, closed) and issue reported in #739. The aim is to display correct billing information, not customer's data, as described in linked issues.

cc @francesco-ooops @Aldeigja @chienandalu

FL-556-2322

@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 970ff35 to 57ba623 Compare January 16, 2024 14:25
@papulo79
Copy link

LGTM

@danielduqma danielduqma marked this pull request as ready for review January 16, 2024 14:41
chienandalu
chienandalu approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielduqma 👍

(maybe you can squash both commits into a single one?)

@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 57ba623 to 48e66fb Compare January 17, 2024 10:35
@danielduqma
Copy link
Author

Thanks @danielduqma 👍

(maybe you can squash both commits into a single one?)

Thanks for the review! I did that way to keep both commits with their authors (@Aldeigja as original one and me for adapting and testing for 16.0), but I better squashed both commits and add him as co-author.

Regards.

@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 48e66fb to 79e2c1a Compare February 5, 2024 10:06
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 79e2c1a to 8d8ad87 Compare April 10, 2024 08:56
@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 8d8ad87 to 91dbefc Compare June 10, 2024 09:11
@danielduqma
Copy link
Author

@OCA/e-commerce-maintainers could anyone merge this, please? Thanks!

@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from 91dbefc to b585de4 Compare October 11, 2024 11:24
@danielduqma
Copy link
Author

@OCA/e-commerce-maintainers could anyone take a look and merge this fix, please? Rebased and runboat running

@danielduqma @Aldeigja
[IMP] website_sale_invoice_address: billing info
f31bfaa 
Display partner invoice address as billing in checkout, instead of
order's partner.

Co-authored-by: George Smirnov <[email protected]>
@danielduqma danielduqma force-pushed the 16.0-fix-website_sale_invoice_address-billing branch from b585de4 to f31bfaa Compare January 10, 2025 12:35
@danielduqma
Copy link
Author

Hi @OCA/e-commerce-maintainers could you please merge this PR? All checks are green and this can be checked in runboat following original issue: #739. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@papulo79 papulo79 papulo79 approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielduqma @papulo79 @OCA-git-bot @chienandalu