[14.0][IMP] base_delivery_carrier_label: show weight field in tree and form view of stock.move.line #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view of stock.move.line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_delivery_carrier_label adds a weight field on stock.move.line (https://github.com/OCA/delivery-carrier/blob/14.0/base_delivery_carrier_label/models/stock_move_line.py#L15), but it's doesn't show it in the view! This PR adds the field in the tree and form view of stock.move.line.
With the field displayed in the user interface, you will see that it's value is always 0... and, when you look at the code, you see that the method get_weight() is only called to write the weight on the package... but it is not used to write the weight on stock.move.line. This PR doesn't fix this, but we need to do something about it !