Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] delivery_package_number: add field for auto printing #762

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] delivery_package_number: add field for auto printing #762

wants to merge 1 commit into from

Conversation

ferran-S73
Copy link
Contributor

I know this may be a bit counterintuitive but the print_label base field is used for sending to shipper so making these labels auto printed by this field has caused an issue in some clients that want to have the shipper feature but don't want the number of packages label.
Best way I've found to resolve the issue is by creating a dedicated field to configure the auto-printing.

@ferran-S73 ferran-S73 changed the title [IMP] delivery_package_number: add field for auto printing [16.0][IMP] delivery_package_number: add field for auto printing Jan 16, 2024
@ferran-S73
Copy link
Contributor Author

@pedrobaeza anyone from tecnativa to review/give opinion on this please? This is due to the last pr you merged #750

@ferran-S73 ferran-S73 force-pushed the 16.0-imp-delivery_package_number branch from 3a2e4fb to 5e87df5 Compare January 16, 2024 11:43
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 16, 2024
@pedrobaeza
Copy link
Member

@sergio-teruel @CarlosRoca13 didn't you develop something similar on v15?

@sergio-teruel
Copy link
Contributor

Yes!!1

@pedrobaeza
Copy link
Member

@ferran-S73 please check 15.0 commits and put this branch up to date with it, and you'll have the feature.

@ferran-S73
Copy link
Contributor Author

@ferran-S73 please check 15.0 commits and put this branch up to date with it, and you'll have the feature.

@pedrobaeza @sergio-teruel I can't seem to find the feature you guys are talking about on v15. Could you point towards which commit is missing please?

@ferran-S73
Copy link
Contributor Author

@pedrobaeza @sergio-teruel just to clarify this a separate field to decide whether the report number of packages should be printed on picking validation, I didn't see any similar feature in any past version. If it does exist could you help me find it?

@CarlosRoca13
Copy link
Contributor

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

  1. Go to picking types.
  2. Set as true Force set number of packages and select the action report that you want to execute.
  3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it:
example

@ferran-S73
Copy link
Contributor Author

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

1. Go to picking types.

2. Set as true Force set number of packages and select the action report that you want to execute.

3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it: example example

Hi @CarlosRoca13 , thank you for the explanation but that isn't the point of this PR. What we want is to not automatically print the report when the picking is validated through any of it's wizards. That is due to those wizards using the base 'print_label' field and the reason I opted for adding a new field. Yo can try for yourself just validate a picking through a wizard (validate it partially for example) without the force set number of packages field and you'll end up with the report number of packages printed if the print_label field is checked.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@ferran-S73
Copy link
Contributor Author

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

1. Go to picking types.

2. Set as true Force set number of packages and select the action report that you want to execute.

3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it: example

    [
      
        ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
      
    ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
   [ ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88) ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
  
    [
      
        ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
      
    ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
   [ ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)

Hi @CarlosRoca13 , thank you for the explanation but that isn't the point of this PR. What we want is to not automatically print the report when the picking is validated through any of it's wizards. That is due to those wizards using the base 'print_label' field and the reason I opted for adding a new field. Yo can try for yourself just validate a picking through a wizard (validate it partially for example) without the force set number of packages field and you'll end up with the report number of packages printed if the print_label field is checked.

@CarlosRoca13 @pedrobaeza could you review please?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 27, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@ferran-S73 ferran-S73 force-pushed the 16.0-imp-delivery_package_number branch from 5e87df5 to 731f1a1 Compare October 16, 2024 10:29
@ferran-S73 ferran-S73 force-pushed the 16.0-imp-delivery_package_number branch from 731f1a1 to 9a9f536 Compare October 16, 2024 10:34
@ferran-S73
Copy link
Contributor Author

@pedrobaeza @CarlosRoca13 could you review my last comment please?

rousseldenis
rousseldenis approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferran-S73
Copy link
Contributor Author

@rousseldenis could you remove the stale label please?

@rousseldenis rousseldenis removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 16, 2024
@CarlosRoca13
Copy link
Contributor

I'm testing what you're saying on a runbot, but I'm not getting any kind of report. I'm not sure if I'm fully understanding what you mean. If you would be so kind, could you please provide a step-by-step list of what I need to do in order for what you don't expect to happen and what you do expect to happen?

@rousseldenis
Copy link
Contributor

@ferran-S73 FYI there is : OCA/stock-logistics-reporting#347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
enhancement needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ferran-S73 @pedrobaeza @sergio-teruel @CarlosRoca13 @rousseldenis