[17.0][IMP] product_contract: Allow creating sales orders with lines that lack a contract template #1185
Conversation
|
Hi @sbejaoui, |
carlos-lopez-tecnativa
force-pushed
the
17.0-product_contract_without_contract_template
branch
from
948aad5 to
bfe552e
Compare
carlos-lopez-tecnativa
force-pushed
the
17.0-product_contract_without_contract_template
branch
from
bfe552e to
5f16126
Compare
|
@sbejaoui do you agree? |
carlos-lopez-tecnativa
force-pushed
the
17.0-product_contract_without_contract_template
branch
from
5f16126 to
5146e47
Compare
| rec._prepare_contract_value(self.env["contract.template"]) | ||
| ) | ||
| contracts.append(contract.id) | ||
| contract._onchange_contract_type() |
There was a problem hiding this comment.
Something to do on contract side to put a TODO to change automatic_price on lines to computed.
There was a problem hiding this comment.
Isn't the same? When you put env[model], a new recordset is instantiated, so no possible pool sharing between successive calls to this.
Isn't it a bit weird as some wanted values are not populated ? |
|
Which values? We have only identified the template name. |
@rousseldenis Please provide me with more details; it is not clear. |
[17.0][DCK] add PR OCA#1185 to repos.yaml See merge request Tecnativa/blegal-odoo!29
…ack a contract template Before this commit, confirming a sales order would raise an exception if any line lacked a configured contract template, preventing the creation of the contract. Now, sales order lines without a contract template are automatically added to a new contract without a template, allowing the process to continue seamlessly.
CarlosRoca13
force-pushed
the
17.0-product_contract_without_contract_template
branch
from
5146e47 to
ac6928f
Compare
|
Merging after some time open for not dealing with conflicts: /ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0c6e804. Thanks a lot for contributing to OCA. ❤️ |
Before this commit, confirming a sales order would raise an exception if any line lacked a configured contract template, preventing the creation of the contract.
Now, sales order lines without a contract template are automatically added to a new contract without a template, allowing the process to continue seamlessly.
TT54544
@Tecnativa @pedrobaeza @CarlosRoca13 @sergio-teruel could you please, review this