[FIX] improve error handling

base_iso3166/models/res_country.py

@@ -27,18 +27,18 @@ class ResCountry(models.Model):
 
     @api.depends("code")
     def _compute_codes(self):
-        for country in self:
+        self.code_alpha3 = False
+        self.code_numeric = False
+
+        for country in self.filtered("code"):
             c = False
-            for country_type in ["countries", "historic_countries"]:
-                try:
-                    c = getattr(pycountry, country_type).get(alpha_2=country.code)
-                except KeyError:
-                    c = getattr(pycountry, country_type).get(alpha2=country.code)
-                if c:
-                    break
+            if country.code:
+                for country_type in ["countries", "historic_countries"]:
+                    res = getattr(pycountry, country_type)
+                    try:
+                        c = res.get(alpha_2=country.code)
+                    except KeyError:
+                        break
             if c:
                 country.code_alpha3 = getattr(c, "alpha_3", getattr(c, "alpha3", False))
                 country.code_numeric = c.numeric
-            else:
-                country.code_alpha3 = False
-                country.code_numeric = False