[14.0][IMP] sale_commission: print partial and document total in report #570
Conversation
|
Hi @pedrobaeza, |
|
@pedrobaeza anything against this? It's a useful change when printing settlement reports for many different settlement lines. WDYS? |
|
Not sure about understanding the changes. Some screenshots of the before and after? |
There was a problem hiding this comment.
Sure @pedrobaeza, on the left current version, on the right this PR
In red: "total" of a single settlement was printed on each page related to that settlement, making it confusing when printing multiple settlements at once.
Now "total" is printed only at the end of a single settlement.
In blue: The total of all settlements printed in the report is explicit.
| <t t-foreach="docs" t-as="o"> | ||
| <t t-call="web.internal_layout"> | ||
| <div class="page"> | ||
| <t t-if="show_doc_total"> | ||
| <div class="text-right"> | ||
| <strong>Document total:</strong> |
There was a problem hiding this comment.
Document total wording seems a bit confusing. Better to put it Global amount or Global commission amount.
There was a problem hiding this comment.
Thank you for the review. Changed the wording as you suggested
aleuffre
force-pushed
the
14.0-report-total-by-month
branch
from
78e7286 to
7687518
Compare
|
Hi @pedrobaeza can this be merged? It's quite a minor change. |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 9e9321d. Thanks a lot for contributing to OCA. ❤️ |
No description provided.