[14.0][FIX]sale_commission_product_criteria: ignore error on create #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ilyasProgrammer, |
PicchiSeba
force-pushed
the
14.0-fix-on-create-error
branch
6 times, most recently
from
b5d12ec to
8a9bf23
Compare
PicchiSeba
force-pushed
the
14.0-fix-on-create-error
branch
from
8a9bf23 to
393caf6
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 5ab7931. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the "Create" button for commision types, the exception at the end of
check_type_change_allowed_movesis raised, without even landing in the commission type form.In this PR we make sure the commission exists in the first place