Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] commission: add the commission_ids field to the settlement and include it in the views #565

Closed
wants to merge 1 commit into from
Closed

[15.0][IMP] commission: add the commission_ids field to the settlement and include it in the views #565

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link
Contributor

This PR improves the user experience by making it easier to understand which commission types are assigned to each settlement record, instead of having to check each settlement line individually.

@qrtl QT4840

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][IMP] comission: add the commission_ids field to the settlement and include it in the views [15.0][IMP] commission: add the commission_ids field to the settlement and include it in the views Oct 10, 2024
yostashiro
yostashiro approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 10, 2024
pedrobaeza
pedrobaeza requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new computed stored field will provoke a collapse updating the module. And anyway, a many2many is not seen very well in a tree view. I prefer this to be done on a custom module.

@AungKoKoLin1997
Copy link
Contributor Author

Closing this PR and will create custom module for this.
@pedrobaeza Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AungKoKoLin1997 @OCA-git-bot @pedrobaeza @yostashiro