[14.0] [IMP] sale_commission_geo_assign #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eLBati, |
renda-dev
changed the title
renda-dev
force-pushed
the
14.0-imp-sale_commission_geo_assign
branch
from
1ee4492 to
9c4cdee
Compare
francesco-ooops
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Functional ok!
This change is both an IMP to features and a clarification of initial behavior (which has been left untouched).
@eLBati good for you?
aleuffre
force-pushed
the
14.0-imp-sale_commission_geo_assign
branch
4 times, most recently
from
60aec4d to
46c519a
Compare
aleuffre
force-pushed
the
14.0-imp-sale_commission_geo_assign
branch
from
46c519a to
f925c46
Compare
|
@pedrobaeza can we merge? |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a1fc50a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve some little things in
sale_commission_geo_assign.With the current situation it's not really helpful in a situation like: "Agent A has stopped working with our company, so Agent B must be assigned to Agent A's former customers"
To address those things there are several improvements: