[14.0][FIX] sale_commission_product_criteria_domain: onchange agents withs …

[ilyasProgrammer]

…restrictions

[aleuffre]

Only code review:

Code looks generally ok, left some minor feedback to improve clarity and readability.

[aleuffre]

Suggested change

	if x._origin.id not in exiting_agents.ids
	if x not in exiting_agents

I think this would be easier and more readable, unless it doesn't work for some reason?

[ilyasProgrammer]

No it does not work, since x is a new instance without id.

[aleuffre]

Maybe there's something I'm missing, but why not work with recordsets directly?

Suggested change

	lambda x: x.agent_id._origin.id
	in (set(exiting_agents.ids) - set(rec.agent_ids.ids))
	lambda x: x.agent_id in (exiting_agents - rec.agent_ids)

[ilyasProgrammer]

Same here. It cant be done using records. Thats why i use ids and sets.

[aleuffre]

This seems to work for me, on both existing partners and partners being created. Could you double check please?

    @api.onchange("agent_ids")
    def _onchange_agent_ids(self):
        for rec in self:
            exiting_agents = rec.commission_item_agent_ids.mapped("agent_id")
            to_create = [
                {
                    "agent_id": x.id,
                    "group_ids": [(6, 0, x.allowed_commission_group_ids.ids)],
                }
                for x in rec.agent_ids.filtered(
                    lambda x: x.commission_id.commission_type == "product_restricted"
                )
                if x not in exiting_agents
            ]
            to_delete = rec.commission_item_agent_ids.filtered(
                lambda x: x.agent_id in (exiting_agents - rec.agent_ids)
            )
            if to_delete:
                rec.update(
                    {"commission_item_agent_ids": [(2, dl.id, 0) for dl in to_delete]}
                )
            if to_create:
                rec.update(
                    {"commission_item_agent_ids": [(0, 0, line) for line in to_create]}
                )

If you confirm that it doesn't work for you I'll drop the issue, since it's no big deal either way, but I'm curious to understand why it wouldn't work.

[ilyasProgrammer]

It works indeed. Must be my mistake. Thanks!

[aleuffre]

Oh, and please follow OCA guidelines for your PR title and your commit message:

• PR title has to indicate the Odoo version at the start `[14.0] (your commit message should not)
• Commit message's first line should not be longer than 80 characters

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[francesco-ooops]

Functional ok!

[aleuffre]

Code review ok

[ilyasProgrammer]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-452-by-ilyasProgrammer-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 4d535ed. Thanks a lot for contributing to OCA. ❤️