Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FW-PORT] account_statement_import_sheet_file: additional mapping controls #740

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[16.0] [FW-PORT] account_statement_import_sheet_file: additional mapping controls #740

merged 1 commit into from
Nov 26, 2024

Conversation

renda-dev
Copy link

FW-PORT of #691 to v16.0

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

@renda-dev renda-dev changed the title [16.0] [FW-PORT] account_statement_import_txt_xlsx: additional mapping controls [16.0] [FW-PORT] account_statement_import_sheet_file: additional mapping controls Nov 15, 2024
@renda-dev renda-dev force-pushed the 16.0-additional-controls branch from 0efa348 to 240edce Compare November 15, 2024 14:08
aleuffre
aleuffre approved these changes Nov 20, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM.

My question relates to a change that was already merged in previous versions, so not blocking.

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py Outdated Show resolved Hide resolved
@renda-dev renda-dev force-pushed the 16.0-additional-controls branch from 240edce to 14fe934 Compare November 20, 2024 11:07
AinohaBH
AinohaBH approved these changes Nov 25, 2024
View reviewed changes
Copy link

@AinohaBH AinohaBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review and this LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 25, 2024
@pedrobaeza
Copy link
Member

Well, I don't see too much value added there, and it creates a lot of noise, specially not being the focus of this PR.

@renda-dev renda-dev force-pushed the 16.0-additional-controls branch from 14fe934 to e68b97b Compare November 25, 2024 14:10
@aleuffre
Copy link

Well, I don't see too much value added there, and it creates a lot of noise, specially not being the focus of this PR.

@pedrobaeza Thank you for reviewing this. We have removed the refactor in order to make the diff smaller and reduce noise.

@pedrobaeza
Copy link
Member

Thanks. The CI is not red.

@renda-dev renda-dev force-pushed the 16.0-additional-controls branch from e68b97b to fe7fd02 Compare November 25, 2024 15:36
@renda-dev renda-dev force-pushed the 16.0-additional-controls branch from fe7fd02 to adb6142 Compare November 25, 2024 15:38
@renda-dev
Copy link
Author

Green light @pedrobaeza :)

Thanks for checking the PR

pedrobaeza
pedrobaeza approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-740-by-pedrobaeza-bump-minor, awaiting test results.

@pedrobaeza
Copy link
Member

Please fw-port it to 17

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 93635a0 into OCA:16.0 Nov 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5930b9. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 16.0-additional-controls branch November 26, 2024 08:45
@renda-dev renda-dev mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh left review comments

@AinohaBH AinohaBH AinohaBH approved these changes

@aleuffre aleuffre aleuffre approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@renda-dev @OCA-git-bot @pedrobaeza @aleuffre @alexey-pelykh @AinohaBH @jdidderen-noviat