[16][FIX] account_statement_import_online_qonto : fix import #718
Conversation
florian-dacosta
changed the title
Fix accounting entry number fix statement line description fix foreign currency import
florian-dacosta
force-pushed
the
16-fix-qonto
branch
from
a074a55
to
7bd1b3d
Compare
It should be ok now @flotho |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-718-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at bfd03cb. Thanks a lot for contributing to OCA. ❤️ |
I think there are some big issues on the v16 module.
Mainly, the
payment_refof the statement line is empty (although it is the main field that give us information about the transaction) and the number (fieldname) of the accounting entry is not the one of the journal, it is the label of the transaction!Probably a confusion due to the fact that
account.bank.statement.lineinheritsaccount.moveThis PR also fix the foreign currency management which is not functional at the moment.
Also remove the verify=False on the calls to qonto.
There are no comment whatsoever indicating why it was done, and this is working fine without it.
The changes comes from 21712f5
I don't know if the module is used already in v16, I guess/hope not, but it would be nice to review/merge this fast as the issues are importants.
@victoralmau @pedrobaeza @carolinafernandez-tecnativa