Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14.0_txt_xlsx_better_error_handling #613

Closed
wants to merge 4 commits into from
Closed

14.0_txt_xlsx_better_error_handling #613

wants to merge 4 commits into from

Commits on Jul 20, 2023

  1. Handle empty str in amount as 0 

    Prevents Decimal Conversion error
    @saravanabalagi
    saravanabalagi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c3961ea View commit details
    Browse the repository at this point in the history

  2. Better error handling 

    Show more common file content problems: Key and Value error
For all other error, report parsing error
    @saravanabalagi
    saravanabalagi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4f0907c View commit details
    Browse the repository at this point in the history

  3. Lint fix

    @saravanabalagi
    saravanabalagi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    25de694 View commit details
    Browse the repository at this point in the history

  4. Catch decimal error separately 

    Print error for BaseException
Add tests and fixtures
    @saravanabalagi
    saravanabalagi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d704823 View commit details
    Browse the repository at this point in the history