Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ADD] account_statement_import_sftp (#14) #606

Merged
merged 4 commits into from
Mar 13, 2024
Merged

[14.0] [ADD] account_statement_import_sftp (#14) #606

merged 4 commits into from
Mar 13, 2024

Conversation

ecino
Copy link

@ecino ecino commented Jun 29, 2023

New module for importing bank statement files directly from a SFTP server through EDI modules.

@simgonzalez @ecino
[ADD] account_statement_import_sftp (#14)
c5fd49f 
* [ADD] account_statement_import_sftp

Add a mechanism to receive file from an sftp back end.

---------

Co-authored-by: ecino <[email protected]>
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@ecino
Copy link
Author

ecino commented Oct 30, 2023

@OCA/banking-maintainers Someone available for review?

@bosd
Copy link
Contributor

bosd commented Nov 3, 2023

@ecino Can you force push to re-trigger runboat creation?

@bosd
Copy link
Contributor

bosd commented Nov 3, 2023

Is it possible to add some tests?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@ecino
Copy link
Author

ecino commented Mar 7, 2024

@bosd Tests are here.

@davidwul @ecino
fix backend name and add auto post feature (#19)
0224919 
* backend type need to be the same name as defined in xml

* Add the auto post ability and the description en the readme.
@ecino ecino force-pushed the 14.0-account_statement_import_sftp branch from 961bcce to 0224919 Compare March 7, 2024 14:23
StefanRijnhart
StefanRijnhart approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using str2bool!

bosd
bosd approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review LGTM ✨

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-606-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 56fd946 into OCA:14.0 Mar 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 539c218. Thanks a lot for contributing to OCA. ❤️

@ecino ecino deleted the 14.0-account_statement_import_sftp branch March 14, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ecino @bosd @OCA-git-bot @StefanRijnhart @simgonzalez @davidwul @lucadela96