Skip to content

Commit

Permalink
[IMP] account_statement_import_camt54: pre-commit auto fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
xaviedoanhduy committed Nov 7, 2024
1 parent be40d16 commit 208172c
Show file tree
Hide file tree
Showing 11 changed files with 124 additions and 95 deletions.
69 changes: 40 additions & 29 deletions account_statement_import_camt54/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,39 +17,47 @@ Bank Account Camt54 Import
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github
:target: https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt54
:target: https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt54
:alt: OCA/bank-statement-import
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt54
:target: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_camt54
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&target_branch=16.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module allows you to import CAMT.054 file (details of customers payments batch) into a dedicated journal taking care of the start/end balance and the remittance reference number.
This module allows you to import CAMT.054 file (details of customers
payments batch) into a dedicated journal taking care of the start/end
balance and the remittance reference number.

Customer invoices will be reconciled/Paid. Payment entries will be posted into an internal transfer account (that you have to create with a type current asset and set on the journal)
Customer invoices will be reconciled/Paid. Payment entries will be
posted into an internal transfer account (that you have to create with a
type current asset and set on the journal)

After this first step, import normally your CAMT.053 (full bank statement) into the bank journal. You will be able to clear the internal transfer account to end up the accounting flow.

Optionally we can activate add generation of additional line in bank statement which will balance your bank statement total to 0.
This line can be consolidated later with different account.
To enable option of final statement line you need properly set flag on Account Journal
Configuration -> Journals -> tab Advanced Settings -> Bank statement configuration
After this first step, import normally your CAMT.053 (full bank
statement) into the bank journal. You will be able to clear the internal
transfer account to end up the accounting flow.

Optionally we can activate add generation of additional line in bank
statement which will balance your bank statement total to 0. This line
can be consolidated later with different account. To enable option of
final statement line you need properly set flag on Account Journal
Configuration -> Journals -> tab Advanced Settings -> Bank statement
configuration

Switzerland localisation
------------------------

For ISR containing a partner reference, uses the config parameter key `isr_partner_ref`.
Doing so will fill the partners on bank statement lines and speed up the matches in the reconciliation process.
For ISR containing a partner reference, uses the config parameter key
isr_partner_ref. Doing so will fill the partners on bank statement lines
and speed up the matches in the reconciliation process.

Value to set in `isr_partner_ref` defines the position of the partner reference inside the ISR.
The format is `i[,n]`
For instance `13,6` to start on position 13 with a 6 digit long reference.
`n` is optional and it's default value is `6`.
Value to set in isr_partner_ref defines the position of the partner
reference inside the ISR. The format is i[,n] For instance 13,6 to start
on position 13 with a 6 digit long reference. n is optional and it's
default value is 6.

**Table of contents**

Expand All @@ -62,35 +70,38 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/bank-statement-import/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt54%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt54%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~
-------

* camptocamp

Contributors
~~~~~~~~~~~~
------------

- Yannick Vaucher <[email protected]>

- Timon Tschanz <[email protected]>

* Yannick Vaucher <[email protected]>
* Timon Tschanz <[email protected]>
* `Trobz <https://trobz.com>`_:
- `Trobz <https://trobz.com>`__:

* Son Ho <[email protected]>
- Son Ho <[email protected]>

Other credits
~~~~~~~~~~~~~
-------------

* Digital4efficiency.ch
* The migration of this module from 15.0 to 16.0 was financially supported by Camptocamp
- Digital4efficiency.ch
- The migration of this module from 15.0 to 16.0 was financially
supported by Camptocamp

Maintainers
~~~~~~~~~~~
-----------

This module is maintained by the OCA.

Expand All @@ -102,6 +113,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/bank-statement-import <https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt54>`_ project on GitHub.
This module is part of the `OCA/bank-statement-import <https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt54>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 0 additions & 1 deletion account_statement_import_camt54/models/account_journal.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@


class AccountBankStatementImport(models.Model):

_inherit = "account.journal"

transfer_line = fields.Boolean(
Expand Down
2 changes: 1 addition & 1 deletion account_statement_import_camt54/models/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def parse_transaction_details(self, ns, node, transaction):
.xpath("./ns:AcctSvcrRef", namespaces={"ns": ns})
)
if trans_id_node:
payment_ref = "{} ({})".format(payment_ref, trans_id_node[0].text)
payment_ref = f"{payment_ref} ({trans_id_node[0].text})"
if payment_ref:
transaction["payment_ref"] = payment_ref
# End add esr to the label.
Expand Down
3 changes: 3 additions & 0 deletions account_statement_import_camt54/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
7 changes: 7 additions & 0 deletions account_statement_import_camt54/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- Yannick Vaucher \<<[email protected]>\>

- Timon Tschanz \<<[email protected]>\>

- [Trobz](https://trobz.com):

> - Son Ho \<<[email protected]>\>
5 changes: 0 additions & 5 deletions account_statement_import_camt54/readme/CONTRIBUTORS.rst

This file was deleted.

3 changes: 3 additions & 0 deletions account_statement_import_camt54/readme/CREDITS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Digital4efficiency.ch
- The migration of this module from 15.0 to 16.0 was financially
supported by Camptocamp
2 changes: 0 additions & 2 deletions account_statement_import_camt54/readme/CREDITS.rst

This file was deleted.

29 changes: 29 additions & 0 deletions account_statement_import_camt54/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
> This module allows you to import CAMT.054 file (details of customers
> payments batch) into a dedicated journal taking care of the start/end
> balance and the remittance reference number.
Customer invoices will be reconciled/Paid. Payment entries will be
posted into an internal transfer account (that you have to create with a
type current asset and set on the journal)

After this first step, import normally your CAMT.053 (full bank
statement) into the bank journal. You will be able to clear the internal
transfer account to end up the accounting flow.

Optionally we can activate add generation of additional line in bank
statement which will balance your bank statement total to 0. This line
can be consolidated later with different account. To enable option of
final statement line you need properly set flag on Account Journal
Configuration -\> Journals -\> tab Advanced Settings -\> Bank statement
configuration

## Switzerland localisation

For ISR containing a partner reference, uses the config parameter key
isr_partner_ref. Doing so will fill the partners on bank statement lines
and speed up the matches in the reconciliation process.

Value to set in isr_partner_ref defines the position of the partner
reference inside the ISR. The format is i\[,n\] For instance 13,6 to
start on position 13 with a 6 digit long reference. n is optional and
it's default value is 6.
22 changes: 0 additions & 22 deletions account_statement_import_camt54/readme/DESCRIPTION.rst

This file was deleted.

Loading

0 comments on commit 208172c

Please sign in to comment.