[18.0][MIG] account_invoice_select_for_payment: Migration to 18.0 #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module allows to mark invoices as "selected for payment". This can be done in the list view of invoices using a button in the first column of the view which shows the selection status. This selection persists until a payment is registered.
Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_invoice_select_for_payment Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_invoice_select_for_payment/sv/
Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_invoice_select_for_payment Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_invoice_select_for_payment/es/
Currently translated at 100.0% (8 of 8 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_invoice_select_for_payment Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_invoice_select_for_payment/it/
Kimkhoi3010
force-pushed
the
18.0-mig-account_invoice_select_for_payment
branch
from
dd535b9 to
47ebee1
Compare
sebalix
reviewed
Nov 28, 2024
grindtildeath
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks for the mig.
Can you please add a small test as suggested by @sebalix ?
Kimkhoi3010
force-pushed
the
18.0-mig-account_invoice_select_for_payment
branch
2 times, most recently
from
2ba1fc0 to
a322a59
Compare
|
Hello @grindtildeath, @sebalix, I updated by your comments |
Kimkhoi3010
force-pushed
the
18.0-mig-account_invoice_select_for_payment
branch
2 times, most recently
from
802abbc to
4799428
Compare
TDu
reviewed
Jan 24, 2025
| @@ -13,5 +13,4 @@ def action_register_payment(self): | |||
| invoices = self.env["account.move"].search( | |||
| [("id", "in", active_ids), ("selected_for_payment", "=", True)] | |||
| ) | |||
| invoices.write({"selected_for_payment": False}) | |||
| return super().action_register_payment() | |||
| return invoices.write({"selected_for_payment": False}) | |||
There was a problem hiding this comment.
Why loose the call to super and could the invoices variable be unassigned ?
There was a problem hiding this comment.
Hi @TDu, I checked again and found out that this function has been moved to the account.move module since Odoo 14.0. I updated the PR. Thank for your comment.
Kimkhoi3010
force-pushed
the
18.0-mig-account_invoice_select_for_payment
branch
from
4799428 to
2c6df2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in 18.0: