[ADD][14.0]account_payment_order_validation_move_line

[syera94]

@florian-dacosta
@alexis-via
for check.
Same than account_payment_order_currency, it should be great if we can talk about it tmw.

[florian-dacosta]

I'd change the module name.

Maybe something like account_payment_order_select_for_payment to be consistent as it is kind of a glue module between account_invoice_select_for_payment and account_payment_order

Also, there is a missing part in the module. Once the payment order is validated (I guess at the step the reconciliation is done), the paid invoices should be unflaggued (the selected_for_payment should be set to False on the invoices, once the payment is done.

[florian-dacosta]

I wonder if the condition should be more complicated, because, this selected_for_payment is only meant to be set on invoices, not in regular accounting entry. But this payment order can accept accounting entry that are not invoices, depending on the filter invoice.

So I guess the domain as it is now is ok in case invoice field is True, but if not, we'd have to have a domain like
['|', '&', ('move_type', 'in', ("in_invoice", "out_invoice", "in_refund", "out_refund")), ("move_id.selected_for_payment", "=", True), ('move_type', '=', 'entry')]
So I would check
if self.invoice and self.select_for_payment_move_line
then add the domain [("move_id.selected_for_payment", "=", True)]
elif self.select_for_payment_move_line
then add the more complex domain to accept regular accounting entries

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.