-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] account_payment_purchase: replace api.onchange by computed field on purchase.order #1167
[16.0] account_payment_purchase: replace api.onchange by computed field on purchase.order #1167
Conversation
0ab4679
to
6c36bc2
Compare
Code review & testing ok. I am wondering why precompute=True is set on the computed fields. |
It's because some fields are already precompute, and the dependency chain should be completely that way for avoiding double computing. |
6c36bc2
to
ecf12fc
Compare
…urchase.order Add check_company=True on the 2 fields of purchase.order
ecf12fc
to
4c3e829
Compare
I also converted (0, 0, {}) to Command.create([}) |
/ocabot merge major |
This PR has the |
/ocabot merge major |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at fc1346a. Thanks a lot for contributing to OCA. ❤️ |
replace api.onchange by computed field on purchase.order
Add company_id in the domain of the fields of purchase.order
Add check_company=True on the 2 fields of purchase.order