-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG][sale_stock_picking_invoicing] #1857
base: 16.0
Are you sure you want to change the base?
Conversation
edbd32f
to
65fa883
Compare
8294336
to
275ce32
Compare
275ce32
to
7755701
Compare
7755701
to
5aaafe2
Compare
@rvalyi @renatonlima about the changes:
analytic_account_id = self.order_id.analytic_account_id.id
if self.analytic_distribution and not self.display_type:
res['analytic_distribution'] = self.analytic_distribution
if analytic_account_id and not self.display_type:
analytic_account_id = str(analytic_account_id)
if 'analytic_distribution' in res:
res['analytic_distribution'][analytic_account_id] = res['analytic_distribution'].get(analytic_account_id, 0) + 100
else:
res['analytic_distribution'] = {analytic_account_id: 100} This value and the sale_line_ids are the only two fields informed when the ''Invoice Type" are out_refund ( Should be informed other fields? Is there another "Invoice Type" that should not copy Sale fields? I let a TODO there https://github.com/akretion/account-invoicing/blob/16.0-mig-sale_stock_picking_invoicing/sale_stock_picking_invoicing/wizards/stock_invoice_onshipping.py#L169 ) Test the copy of field: Analytic Lines seems to be change as Mixin in the module https://github.com/OCA/OCB/tree/16.0/addons/analytic
I did the changes in new commits to make easy to see the diff, but can be just a amend in one MIG commit, let me know if will be better only one commit. With this changes I think the PR can be move from status Draft to Ready to Review |
cc @mbcosta @renatonlima
EDIT: I put it in draft as I'm not too sure yet what should should be done for analytical fields around 65fa883#diff-d8a5810924c9e2509dedcd08b9b6aea083a8543de434b845310fbe7f0c501b58R163
Suggestions are welcome.