Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG][sale_stock_picking_invoicing] #1857

Open
wants to merge 10 commits into
base: 16.0
Choose a base branch
from

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Dec 2, 2024

cc @mbcosta @renatonlima

EDIT: I put it in draft as I'm not too sure yet what should should be done for analytical fields around 65fa883#diff-d8a5810924c9e2509dedcd08b9b6aea083a8543de434b845310fbe7f0c501b58R163
Suggestions are welcome.

@mbcosta mbcosta force-pushed the 16.0-mig-sale_stock_picking_invoicing branch from 275ce32 to 7755701 Compare January 14, 2025 23:08
@mbcosta mbcosta force-pushed the 16.0-mig-sale_stock_picking_invoicing branch from 7755701 to 5aaafe2 Compare January 15, 2025 12:01
@mbcosta
Copy link
Contributor

mbcosta commented Jan 15, 2025

@rvalyi @renatonlima about the changes:

        analytic_account_id = self.order_id.analytic_account_id.id
        if self.analytic_distribution and not self.display_type:
            res['analytic_distribution'] = self.analytic_distribution
        if analytic_account_id and not self.display_type:
            analytic_account_id = str(analytic_account_id)
            if 'analytic_distribution' in res:
                res['analytic_distribution'][analytic_account_id] = res['analytic_distribution'].get(analytic_account_id, 0) + 100
            else:
                res['analytic_distribution'] = {analytic_account_id: 100}

This value and the sale_line_ids are the only two fields informed when the ''Invoice Type" are out_refund ( Should be informed other fields? Is there another "Invoice Type" that should not copy Sale fields? I let a TODO there https://github.com/akretion/account-invoicing/blob/16.0-mig-sale_stock_picking_invoicing/sale_stock_picking_invoicing/wizards/stock_invoice_onshipping.py#L169 )

Test the copy of field:

image

image

image

Analytic Lines seems to be change as Mixin in the module https://github.com/OCA/OCB/tree/16.0/addons/analytic

I did the changes in new commits to make easy to see the diff, but can be just a amend in one MIG commit, let me know if will be better only one commit.

With this changes I think the PR can be move from status Draft to Ready to Review

@rvalyi rvalyi marked this pull request as ready for review January 24, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants