Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] account_invoice_report_utm_campaign : adds Campaign, Medium, and Source to analysis report #335

Merged

Conversation

nayatec
Copy link
Contributor

@nayatec nayatec commented Sep 18, 2024

This module adds the Campaign, Medium, and Source fields to the Invoice Analysis report.

@nayatec nayatec force-pushed the 14.0-add-account_invoice_report_utm_campaign branch from 84f8a0d to 144f6c4 Compare September 18, 2024 08:29
@nayatec nayatec changed the title [14.0][ADD] account_invoice_report_utm_campaign [14.0][ADD] account_invoice_report_utm_campaign : adds Campaign, Medium, and Source to analysis report Sep 18, 2024
Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank

"website": "https://github.com/OCA/account-invoice-reporting",
"author": "Akretion, Odoo Community Association (OCA)",
"license": "AGPL-3",
"installable": True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forget to add yourself as maintainer

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(resolved)

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, works as expected. Thanks @nayatec

@bguillot
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-335-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3fe1e7d into OCA:14.0 Sep 20, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ffeb2f2. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

Why it is called account_invoice_report_utm_campaign instead of just account_invoice_report_utm, adding the 3 UTM fields?

@nayatec
Copy link
Contributor Author

nayatec commented Sep 23, 2024

Hello @pedrobaeza you have a point here... As a matter of fact i named it after another module we made with a similar name because we thought that "utm_campaign" helps to better contextualize the module. I'll rename it when proposing the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants